threads / patch / 50459

patchFix typo: "git bisectreset" -> "git bisect reset"

Subject: [PATCH] Fix typo: "git bisectreset" -> "git bisect reset"

## tl;dr

3 messages between Feb 11, 2019 and Feb 11, 2019. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Jiang Xin· Feb 11, 2019, 03:06 UTC · lore

Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
---
 builtin/bisect--helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to builtin/bisect--helper.c +1 −1

diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index c1cff32661..5f0b4bddf1 100644
--- a/builtin/bisect--helper.c
+++ b/builtin/bisect--helper.c
@@ -173,7 +173,7 @@ static int bisect_reset(const char *commit)
 			argv_array_clear(&argv);
 			return error(_("could not check out original"
 				       " HEAD '%s'. Try 'git bisect"
-				       "reset <commit>'."), branch.buf);
+				       " reset <commit>'."), branch.buf);
 		}
 		argv_array_clear(&argv);
 	}

-- 
2.21.0.rc0.38.ga5fda54cc5

Eric Sunshine· Feb 11, 2019, 03:46 UTC · re: Jiang Xin · lore

Re: [PATCH] Fix typo: "git bisectreset" -> "git bisect reset"

On Sun, Feb 10, 2019 at 10:07 PM Jiang Xin <worldhello.net@gmail.com> wrote:

Show 7 quoted lines

> diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
> @@ -173,7 +173,7 @@ static int bisect_reset(const char *commit)
>                         return error(_("could not check out original"
>                                        " HEAD '%s'. Try 'git bisect"
> -                                      "reset <commit>'."), branch.buf);
> +                                      " reset <commit>'."), branch.buf);
>                 }

This duplicates a change made by [1], although that patch was withdrawn (temporarily).

[1]: http://public-inbox.org/git/20190209213044.29539-1-jn.avila@free.fr/

Jiang Xin· Feb 11, 2019, 07:48 UTC · re: Eric Sunshine · lore

Re: [PATCH] Fix typo: "git bisectreset" -> "git bisect reset"

Eric Sunshine <sunshine@sunshineco.com> 于2019年2月11日周一 上午11:47写道：

Show 14 quoted lines

>
> On Sun, Feb 10, 2019 at 10:07 PM Jiang Xin <worldhello.net@gmail.com> wrote:
> > diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
> > @@ -173,7 +173,7 @@ static int bisect_reset(const char *commit)
> >                         return error(_("could not check out original"
> >                                        " HEAD '%s'. Try 'git bisect"
> > -                                      "reset <commit>'."), branch.buf);
> > +                                      " reset <commit>'."), branch.buf);
> >                 }
>
> This duplicates a change made by [1], although that patch was
> withdrawn (temporarily).
>
> [1]: http://public-inbox.org/git/20190209213044.29539-1-jn.avila@free.fr/

Thank you for reminding. Please use Jean-Noël's patch v2 (forgot add v2 suffix?).