# [PATCH] Fix typos in translatable strings for v2.21.0 6 messages from 2019-02-09 to 2019-02-11. Participants: Jean-Noël Avila, Jean-Noël AVILA, Jiang Xin, Junio C Hamano. Thread: https://gitlist.dev/t/50452 ## Jean-Noël Avila, 2019-02-09 21:30 Subject: [PATCH] Fix typos in translatable strings for v2.21.0 Message-ID: <20190209213044.29539-1-jn.avila@free.fr> URL: https://gitlist.dev/e/20190209213044.29539-1-jn.avila%40free.fr ``` Signed-off-by: Jean-Noël Avila --- builtin/bisect--helper.c | 4 ++-- builtin/fetch.c | 2 +- builtin/rebase.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index c1cff32661..e7325fe37f 100644 --- a/builtin/bisect--helper.c +++ b/builtin/bisect--helper.c @@ -173,7 +173,7 @@ static int bisect_reset(const char *commit) argv_array_clear(&argv); return error(_("could not check out original" " HEAD '%s'. Try 'git bisect" - "reset '."), branch.buf); + " reset '."), branch.buf); } argv_array_clear(&argv); } @@ -646,7 +646,7 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix) OPT_BOOL(0, "no-checkout", &no_checkout, N_("update BISECT_HEAD instead of checking out the current commit")), OPT_BOOL(0, "no-log", &nolog, - N_("no log for BISECT_WRITE ")), + N_("no log for BISECT_WRITE")), OPT_END() }; struct bisect_terms terms = { .term_good = NULL, .term_bad = NULL }; diff --git a/builtin/fetch.c b/builtin/fetch.c index 5a09fe24cd..b620fd54b4 100644 --- a/builtin/fetch.c +++ b/builtin/fetch.c @@ -1480,7 +1480,7 @@ static inline void fetch_one_setup_partial(struct remote *remote) if (strcmp(remote->name, repository_format_partial_clone)) { if (filter_options.choice) die(_("--filter can only be used with the remote " - "configured in extensions.partialclone")); + "configured in extensions.partialClone")); return; } diff --git a/builtin/rebase.c b/builtin/rebase.c index 96efd40901..1c39abc02e 100644 --- a/builtin/rebase.c +++ b/builtin/rebase.c @@ -1434,7 +1434,7 @@ int cmd_rebase(int argc, const char **argv, const char *prefix) } if (options.reschedule_failed_exec && !is_interactive(&options)) - die(_("--reschedule-failed-exec requires an interactive rebase")); + die(_("%s requires an interactive rebase", "--reschedule-failed-exec")); if (options.git_am_opts.argc) { /* all am options except -q are compatible only with --am */ -- 2.21.0.rc0 ``` ## Jean-Noël AVILA, 2019-02-09 21:33 Subject: Re: [PATCH] Fix typos in translatable strings for v2.21.0 Message-ID: <2525576.bgtBK8p9MF@cayenne> URL: https://gitlist.dev/e/2525576.bgtBK8p9MF%40cayenne In-Reply-To: <20190209213044.29539-1-jn.avila@free.fr> ``` Please forget this one. Will re-submit. ``` ## Jean-Noël Avila, 2019-02-11 06:44 Subject: [PATCH] Fix typos in translatable strings for v2.21.0 Message-ID: <20190211064453.5205-1-jn.avila@free.fr> URL: https://gitlist.dev/e/20190211064453.5205-1-jn.avila%40free.fr In-Reply-To: <20190209213044.29539-1-jn.avila@free.fr> ``` Signed-off-by: Jean-Noël Avila --- builtin/bisect--helper.c | 4 ++-- builtin/fetch.c | 2 +- builtin/rebase.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index c1cff32661..e7325fe37f 100644 --- a/builtin/bisect--helper.c +++ b/builtin/bisect--helper.c @@ -173,7 +173,7 @@ static int bisect_reset(const char *commit) argv_array_clear(&argv); return error(_("could not check out original" " HEAD '%s'. Try 'git bisect" - "reset '."), branch.buf); + " reset '."), branch.buf); } argv_array_clear(&argv); } @@ -646,7 +646,7 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix) OPT_BOOL(0, "no-checkout", &no_checkout, N_("update BISECT_HEAD instead of checking out the current commit")), OPT_BOOL(0, "no-log", &nolog, - N_("no log for BISECT_WRITE ")), + N_("no log for BISECT_WRITE")), OPT_END() }; struct bisect_terms terms = { .term_good = NULL, .term_bad = NULL }; diff --git a/builtin/fetch.c b/builtin/fetch.c index 5a09fe24cd..b620fd54b4 100644 --- a/builtin/fetch.c +++ b/builtin/fetch.c @@ -1480,7 +1480,7 @@ static inline void fetch_one_setup_partial(struct remote *remote) if (strcmp(remote->name, repository_format_partial_clone)) { if (filter_options.choice) die(_("--filter can only be used with the remote " - "configured in extensions.partialclone")); + "configured in extensions.partialClone")); return; } diff --git a/builtin/rebase.c b/builtin/rebase.c index 96efd40901..7c7bc13e91 100644 --- a/builtin/rebase.c +++ b/builtin/rebase.c @@ -1434,7 +1434,7 @@ int cmd_rebase(int argc, const char **argv, const char *prefix) } if (options.reschedule_failed_exec && !is_interactive(&options)) - die(_("--reschedule-failed-exec requires an interactive rebase")); + die(_("%s requires an interactive rebase"), "--reschedule-failed-exec"); if (options.git_am_opts.argc) { /* all am options except -q are compatible only with --am */ -- 2.21.0.rc0 ``` ## Jiang Xin, 2019-02-11 08:09 Subject: Re: [PATCH] Fix typos in translatable strings for v2.21.0 Message-ID: URL: https://gitlist.dev/e/CANYiYbHoNV%2B6yi6a75oh2nPpihsqEu0Fq%2B8R_G6O%2BXOD5JogoQ%40mail.gmail.com In-Reply-To: <20190211064453.5205-1-jn.avila@free.fr> ``` Jean-Noël Avila 于2019年2月11日周一 下午2:48写道： > > Signed-off-by: Jean-Noël Avila > --- > builtin/bisect--helper.c | 4 ++-- > builtin/fetch.c | 2 +- > builtin/rebase.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) This re-roll is v2 (forgot suffix v2 in subject), and LGTM. Difference between v1 and v2: - die(_("--reschedule-failed-exec requires an interactive rebase")); -+ die(_("%s requires an interactive rebase", "--reschedule-failed-exec")); ++ die(_("%s requires an interactive rebase"), "--reschedule-failed-exec"); > > diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c > index c1cff32661..e7325fe37f 100644 > --- a/builtin/bisect--helper.c > +++ b/builtin/bisect--helper.c > @@ -173,7 +173,7 @@ static int bisect_reset(const char *commit) > argv_array_clear(&argv); > return error(_("could not check out original" > " HEAD '%s'. Try 'git bisect" > - "reset '."), branch.buf); > + " reset '."), branch.buf); fixed typo: git bisectreset -> git bisect reset > } > argv_array_clear(&argv); > } > @@ -646,7 +646,7 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix) > OPT_BOOL(0, "no-checkout", &no_checkout, > N_("update BISECT_HEAD instead of checking out the current commit")), > OPT_BOOL(0, "no-log", &nolog, > - N_("no log for BISECT_WRITE ")), > + N_("no log for BISECT_WRITE")), strip trailing writespace. > OPT_END() > }; > struct bisect_terms terms = { .term_good = NULL, .term_bad = NULL }; > diff --git a/builtin/fetch.c b/builtin/fetch.c > index 5a09fe24cd..b620fd54b4 100644 > --- a/builtin/fetch.c > +++ b/builtin/fetch.c > @@ -1480,7 +1480,7 @@ static inline void fetch_one_setup_partial(struct remote *remote) > if (strcmp(remote->name, repository_format_partial_clone)) { > if (filter_options.choice) > die(_("--filter can only be used with the remote " > - "configured in extensions.partialclone")); > + "configured in extensions.partialClone")); Use camelcase for config variable name. > return; > } > > diff --git a/builtin/rebase.c b/builtin/rebase.c > index 96efd40901..7c7bc13e91 100644 > --- a/builtin/rebase.c > +++ b/builtin/rebase.c > @@ -1434,7 +1434,7 @@ int cmd_rebase(int argc, const char **argv, const char *prefix) > } > > if (options.reschedule_failed_exec && !is_interactive(&options)) > - die(_("--reschedule-failed-exec requires an interactive rebase")); > + die(_("%s requires an interactive rebase"), "--reschedule-failed-exec"); Reuse l10n string ("%s requires an interactive rebase") defined in builtin/rebase.c:121: case REBASE_AM: die(_("%s requires an interactive rebase"), option); > > if (options.git_am_opts.argc) { > /* all am options except -q are compatible only with --am */ > -- > 2.21.0.rc0 > ``` ## Jean-Noël Avila, 2019-02-11 08:50 Subject: Re: [PATCH] Fix typos in translatable strings for v2.21.0 Message-ID: <1517c545-0028-56e4-fc58-fb3c6d3551fe@free.fr> URL: https://gitlist.dev/e/1517c545-0028-56e4-fc58-fb3c6d3551fe%40free.fr In-Reply-To: ``` On 11 février 2019, Jiang Xin wrote: > Jean-Noël Avila 于2019年2月11日周一 下午2:48写道： >> Signed-off-by: Jean-Noël Avila >> --- >> builtin/bisect--helper.c | 4 ++-- >> builtin/fetch.c | 2 +- >> builtin/rebase.c | 2 +- >> 3 files changed, 4 insertions(+), 4 deletions(-) > This re-roll is v2 (forgot suffix v2 in subject), and LGTM. > Difference between v1 and v2: > > - die(_("--reschedule-failed-exec requires an > interactive rebase")); > -+ die(_("%s requires an interactive rebase", > "--reschedule-failed-exec")); > ++ die(_("%s requires an interactive rebase"), > "--reschedule-failed-exec"); Thanks for reviewing. The first submission was too hasty and did not even compile. ``` ## Junio C Hamano, 2019-02-11 20:57 Subject: Re: [PATCH] Fix typos in translatable strings for v2.21.0 Message-ID: URL: https://gitlist.dev/e/xmqqo97igi12.fsf%40gitster-ct.c.googlers.com In-Reply-To: <1517c545-0028-56e4-fc58-fb3c6d3551fe@free.fr> ``` Jean-Noël Avila writes: > On 11 février 2019, Jiang Xin wrote: > >> Jean-Noël Avila 于2019年2月11日周一 下午2:48写道： >>> Signed-off-by: Jean-Noël Avila >>> --- >>> builtin/bisect--helper.c | 4 ++-- >>> builtin/fetch.c | 2 +- >>> builtin/rebase.c | 2 +- >>> 3 files changed, 4 insertions(+), 4 deletions(-) >> This re-roll is v2 (forgot suffix v2 in subject), and LGTM. >> Difference between v1 and v2: >> >> - die(_("--reschedule-failed-exec requires an >> interactive rebase")); >> -+ die(_("%s requires an interactive rebase", >> "--reschedule-failed-exec")); >> ++ die(_("%s requires an interactive rebase"), >> "--reschedule-failed-exec"); > Thanks for reviewing. The first submission was too hasty and did not > even compile. Thanks, both. Will queue. ```