# [Fix v1] t5403: correct bash ambiguous redirect error in subtest 8 by quoting $GIT_DIR

2 messages from 2019-02-08 to 2019-02-08. Participants: randall.s.becker@rogers.com, Junio C Hamano.
Thread: https://gitlist.dev/t/50437

## randall.s.becker@rogers.com, 2019-02-08 11:32

Subject: [Fix v1] t5403: correct bash ambiguous redirect error in subtest 8 by quoting $GIT_DIR
Message-ID: <20190208113233.14544-1-randall.s.becker@rogers.com>
URL: https://gitlist.dev/e/20190208113233.14544-1-randall.s.becker%40rogers.com

```
From: "Randall S. Becker" <rsbecker@nexbridge.com>

The embedded blanks in the full path of the test git repository cased bash
to generate an ambugious redirect error.

Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
---
 t/t5403-post-checkout-hook.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/t5403-post-checkout-hook.sh b/t/t5403-post-checkout-hook.sh
index a539ffc08..a39b3b5c7 100755
--- a/t/t5403-post-checkout-hook.sh
+++ b/t/t5403-post-checkout-hook.sh
@@ -67,7 +67,7 @@ test_expect_success 'post-checkout is triggered on rebase with fast-forward' '
 test_expect_success 'post-checkout hook is triggered by clone' '
 	mkdir -p templates/hooks &&
 	write_script templates/hooks/post-checkout <<-\EOF &&
-	echo "$@" >$GIT_DIR/post-checkout.args
+	echo "$@" >"$GIT_DIR/post-checkout.args"
 	EOF
 	git clone --template=templates . clone3 &&
 	test -f clone3/.git/post-checkout.args
-- 
2.12.3


```

## Junio C Hamano, 2019-02-08 19:55

Subject: Re: [Fix v1] t5403: correct bash ambiguous redirect error in subtest 8 by quoting $GIT_DIR
Message-ID: <xmqqh8dejbra.fsf@gitster-ct.c.googlers.com>
URL: https://gitlist.dev/e/xmqqh8dejbra.fsf%40gitster-ct.c.googlers.com
In-Reply-To: <20190208113233.14544-1-randall.s.becker@rogers.com>

```
randall.s.becker@rogers.com writes:

> From: "Randall S. Becker" <rsbecker@nexbridge.com>
>
> The embedded blanks in the full path of the test git repository cased bash
> to generate an ambugious redirect error.
>
> Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
> ---

Thanks.

>  t/t5403-post-checkout-hook.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t5403-post-checkout-hook.sh b/t/t5403-post-checkout-hook.sh
> index a539ffc08..a39b3b5c7 100755
> --- a/t/t5403-post-checkout-hook.sh
> +++ b/t/t5403-post-checkout-hook.sh
> @@ -67,7 +67,7 @@ test_expect_success 'post-checkout is triggered on rebase with fast-forward' '
>  test_expect_success 'post-checkout hook is triggered by clone' '
>  	mkdir -p templates/hooks &&
>  	write_script templates/hooks/post-checkout <<-\EOF &&
> -	echo "$@" >$GIT_DIR/post-checkout.args
> +	echo "$@" >"$GIT_DIR/post-checkout.args"
>  	EOF
>  	git clone --template=templates . clone3 &&
>  	test -f clone3/.git/post-checkout.args

```