# [Breakage] Git v2.21.0-rc0 - t5403 (NonStop) 8 messages from 2019-02-08 to 2019-02-09. Participants: Randall S. Becker, Johannes Schindelin, SZEDER Gábor, Todd Zullinger. Thread: https://gitlist.dev/t/50435 ## Randall S. Becker, 2019-02-08 10:48 Subject: [Breakage] Git v2.21.0-rc0 - t5403 (NonStop) Message-ID: <000d01d4bf9b$d5d48da0$817da8e0$@nexbridge.com> URL: https://gitlist.dev/e/000d01d4bf9b%24d5d48da0%24817da8e0%24%40nexbridge.com ``` Hi All, We have a few new breakages on the NonStop port in 2.21.0-rc0. The first is in t5403, as below: /home/git/git/t/trash directory.t5403-post-checkout-hook/clone3/.git/hooks/post-checkout: line 2: $GIT_DIR/post-checkout.args: ambiguous redirect not ok 8 - post-checkout hook is triggered by clone # # mkdir -p templates/hooks && # write_script templates/hooks/post-checkout <<-\EOF && # echo "$@" >$GIT_DIR/post-checkout.args # EOF # git clone --template=templates . clone3 && # test -f clone3/.git/post-checkout.args # The post-checkout hook is: #!/usr/local/bin/bash echo "$@" >$GIT_DIR/post-checkout.args This looks like it is a "bash thing" and $GIT_DIR might have to be in quotes, and is not be specific to the platform. If I replace echo "$@" >$GIT_DIR/post-checkout.args with echo "$@" >"$GIT_DIR/post-checkout.args" The test passes. I wonder I should provide this patch or whether the author would like to do so. Thanks, Randall ``` ## Johannes Schindelin, 2019-02-08 10:55 Subject: Re: [Breakage] Git v2.21.0-rc0 - t5403 (NonStop) Message-ID: URL: https://gitlist.dev/e/nycvar.QRO.7.76.6.1902081155000.41%40tvgsbejvaqbjf.bet In-Reply-To: <000d01d4bf9b$d5d48da0$817da8e0$@nexbridge.com> ``` Hi Randall, On Fri, 8 Feb 2019, Randall S. Becker wrote: > This looks like it is a "bash thing" and $GIT_DIR might have to be in > quotes, and is not be specific to the platform. If I replace > > echo "$@" >$GIT_DIR/post-checkout.args > > with > > echo "$@" >"$GIT_DIR/post-checkout.args" > > The test passes. I wonder I should provide this patch or whether the > author would like to do so. It is the correct fix, you came up with it, why not simply provide a patch yourself? Thanks, Dscho ``` ## Randall S. Becker, 2019-02-08 10:58 Subject: RE: [Breakage] Git v2.21.0-rc0 - t5403 (NonStop) Message-ID: <000e01d4bf9d$38df5c80$aa9e1580$@nexbridge.com> URL: https://gitlist.dev/e/000e01d4bf9d%2438df5c80%24aa9e1580%24%40nexbridge.com In-Reply-To: ``` On February 8, 2019 5:56, Johannes Schindelin wrote: > To: Randall S. Becker > Cc: 'Junio C Hamano' ; git@vger.kernel.org; 'Linux > Kernel' ; git-packagers@googlegroups.com > Subject: Re: [Breakage] Git v2.21.0-rc0 - t5403 (NonStop) > > Hi Randall, > > On Fri, 8 Feb 2019, Randall S. Becker wrote: > > > This looks like it is a "bash thing" and $GIT_DIR might have to be in > > quotes, and is not be specific to the platform. If I replace > > > > echo "$@" >$GIT_DIR/post-checkout.args > > > > with > > > > echo "$@" >"$GIT_DIR/post-checkout.args" > > > > The test passes. I wonder I should provide this patch or whether the > > author would like to do so. > > It is the correct fix, you came up with it, why not simply provide a patch > yourself? Will do (later today) ``` ## SZEDER Gábor, 2019-02-08 11:10 Subject: Re: [Breakage] Git v2.21.0-rc0 - t5403 (NonStop) Message-ID: <20190208111002.GU10587@szeder.dev> URL: https://gitlist.dev/e/20190208111002.GU10587%40szeder.dev In-Reply-To: <000d01d4bf9b$d5d48da0$817da8e0$@nexbridge.com> ``` On Fri, Feb 08, 2019 at 05:48:27AM -0500, Randall S. Becker wrote: > We have a few new breakages on the NonStop port in 2.21.0-rc0. The first is in t5403, as below: > > /home/git/git/t/trash directory.t5403-post-checkout-hook/clone3/.git/hooks/post-checkout: line 2: $GIT_DIR/post-checkout.args: ambiguous redirect > not ok 8 - post-checkout hook is triggered by clone > # > # mkdir -p templates/hooks && > # write_script templates/hooks/post-checkout <<-\EOF && > # echo "$@" >$GIT_DIR/post-checkout.args > # EOF > # git clone --template=templates . clone3 && > # test -f clone3/.git/post-checkout.args > # > > The post-checkout hook is: > #!/usr/local/bin/bash > echo "$@" >$GIT_DIR/post-checkout.args > > This looks like it is a "bash thing" and $GIT_DIR might have to be in quotes, and is not be specific to the platform. If I replace > > echo "$@" >$GIT_DIR/post-checkout.args > > with > > echo "$@" >"$GIT_DIR/post-checkout.args" > > The test passes. Wow, this is the second time this "redirection to a filename with spaces under Bash" issue pops up today, see the other one here: https://public-inbox.org/git/20190208031746.22683-2-tmz@pobox.com/T/#u In short, Bash (when invoked as bash) doesn't conform to POSIX in this respect; for a (too detailed) explanation see: https://public-inbox.org/git/20180926121107.GH27036@localhost/ Even our CodingGuidelines suggest the use of quotes around the redirection's target. > I wonder I should provide this patch or whether the author would like to do so. Well, since you didn't Cc the author, he might very well overlook this issue, so I think you should ;) ``` ## Randall S. Becker, 2019-02-08 11:36 Subject: RE: [Breakage] Git v2.21.0-rc0 - t5403 (NonStop) Message-ID: <001001d4bfa2$84dcff70$8e96fe50$@nexbridge.com> URL: https://gitlist.dev/e/001001d4bfa2%2484dcff70%248e96fe50%24%40nexbridge.com In-Reply-To: <20190208111002.GU10587@szeder.dev> ``` On February 8, 2019 6:10, SZEDER Gábor > On Fri, Feb 08, 2019 at 05:48:27AM -0500, Randall S. Becker wrote: > > We have a few new breakages on the NonStop port in 2.21.0-rc0. The first > is in t5403, as below: > > > > /home/git/git/t/trash > > directory.t5403-post-checkout-hook/clone3/.git/hooks/post-checkout: > > line 2: $GIT_DIR/post-checkout.args: ambiguous redirect not ok 8 - post- > checkout hook is triggered by clone # > > # mkdir -p templates/hooks && > > # write_script templates/hooks/post-checkout <<-\EOF && > > # echo "$@" >$GIT_DIR/post-checkout.args > > # EOF > > # git clone --template=templates . clone3 && > > # test -f clone3/.git/post-checkout.args > > # > > > > The post-checkout hook is: > > #!/usr/local/bin/bash > > echo "$@" >$GIT_DIR/post-checkout.args > > > > This looks like it is a "bash thing" and $GIT_DIR might have to be in > > quotes, and is not be specific to the platform. If I replace > > > > echo "$@" >$GIT_DIR/post-checkout.args > > > > with > > > > echo "$@" >"$GIT_DIR/post-checkout.args" > > > > The test passes. > > Wow, this is the second time this "redirection to a filename with spaces > under Bash" issue pops up today, see the other one here: > > https://public-inbox.org/git/20190208031746.22683-2- > tmz@pobox.com/T/#u > > In short, Bash (when invoked as bash) doesn't conform to POSIX in this > respect; for a (too detailed) explanation see: > > https://public-inbox.org/git/20180926121107.GH27036@localhost/ > > Even our CodingGuidelines suggest the use of quotes around the > redirection's target. > > > I wonder I should provide this patch or whether the author would like to do > so. > > Well, since you didn't Cc the author, he might very well overlook this issue, > so I think you should ;) + Nguyen and Orgad Thanks. Fix has been submitted as a patch. This is definitely a common one. 😊 ``` ## Todd Zullinger, 2019-02-08 20:11 Subject: Re: [Breakage] Git v2.21.0-rc0 - t5403 (NonStop) Message-ID: <20190208201128.GD30548@zaya.teonanacatl.net> URL: https://gitlist.dev/e/20190208201128.GD30548%40zaya.teonanacatl.net In-Reply-To: <20190208111002.GU10587@szeder.dev> ``` SZEDER Gábor wrote: > On Fri, Feb 08, 2019 at 05:48:27AM -0500, Randall S. Becker wrote: >> We have a few new breakages on the NonStop port in 2.21.0-rc0. The first is in t5403, as below: [...] >> The post-checkout hook is: >> #!/usr/local/bin/bash >> echo "$@" >$GIT_DIR/post-checkout.args >> >> This looks like it is a "bash thing" and $GIT_DIR might have to be in quotes, and is not be specific to the platform. If I replace >> >> echo "$@" >$GIT_DIR/post-checkout.args >> >> with >> >> echo "$@" >"$GIT_DIR/post-checkout.args" >> >> The test passes. > > Wow, this is the second time this "redirection to a filename with > spaces under Bash" issue pops up today, see the other one here: > > https://public-inbox.org/git/20190208031746.22683-2-tmz@pobox.com/T/#u Indeed, I was surprised to see another one today. It made me wonder how I had missed it in my own testing. This one requires SHELL_PATH to be bash, while I only set TEST_SHELL_PATH to bash for the improved -x tracing in the fedora builds. I ran the tests again with SHELL_PATH as bash on fedora and this was the only failure I saw (other than the one from my earlier message, that is). -- Todd ``` ## SZEDER Gábor, 2019-02-08 20:30 Subject: Re: [Breakage] Git v2.21.0-rc0 - t5403 (NonStop) Message-ID: <20190208203009.GC10587@szeder.dev> URL: https://gitlist.dev/e/20190208203009.GC10587%40szeder.dev In-Reply-To: <20190208201128.GD30548@zaya.teonanacatl.net> ``` On Fri, Feb 08, 2019 at 03:11:29PM -0500, Todd Zullinger wrote: > It made me wonder how I had missed it in my own testing. > This one requires SHELL_PATH to be bash, while I only set > TEST_SHELL_PATH to bash for the improved -x tracing in the > fedora builds. Note that you don't need Bash to use '-x' tracing since a5bf824f3b (t: prevent '-x' tracing from interfering with test helpers' stderr, 2018-02-25) and the followup commits, except for 't1510-repo-setup.sh' (and even t1510 just falls back to ignore '-x' instead of causing failures). ``` ## Todd Zullinger, 2019-02-09 06:48 Subject: Re: [Breakage] Git v2.21.0-rc0 - t5403 (NonStop) Message-ID: <20190209064821.GG30548@zaya.teonanacatl.net> URL: https://gitlist.dev/e/20190209064821.GG30548%40zaya.teonanacatl.net In-Reply-To: <20190208203009.GC10587@szeder.dev> ``` [-cc: linux-kernel & git-packagers] SZEDER Gábor wrote: > On Fri, Feb 08, 2019 at 03:11:29PM -0500, Todd Zullinger wrote: >> It made me wonder how I had missed it in my own testing. >> This one requires SHELL_PATH to be bash, while I only set >> TEST_SHELL_PATH to bash for the improved -x tracing in the >> fedora builds. > > Note that you don't need Bash to use '-x' tracing since a5bf824f3b (t: > prevent '-x' tracing from interfering with test helpers' stderr, > 2018-02-25) and the followup commits, except for 't1510-repo-setup.sh' > (and even t1510 just falls back to ignore '-x' instead of causing > failures). Huh, cool. I somehow missed that nice improvement. Thanks for all your fine work on the test suite! It makes my life as a packager much better having a robust test suite running with each build. -- Todd ```