# [PATCH] merge-recur: fix thinko in unique_path() 1 messages from 2006-07-30 to 2006-07-30. Participants: Johannes Schindelin. Thread: https://gitlist.dev/t/5043 ## Johannes Schindelin, 2006-07-30 16:35 Subject: [PATCH] merge-recur: fix thinko in unique_path() Message-ID: URL: https://gitlist.dev/e/Pine.LNX.4.63.0607301835020.29667%40wbgn013.biozentrum.uni-wuerzburg.de ``` This could result in a nasty infinite loop, or in bogus names (it used the strlen() of the newly allocated buffer instead of the original buffer). Signed-off-by: Johannes Schindelin --- merge-recursive.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/merge-recursive.c b/merge-recursive.c index 6a796f2..5375a1b 100644 --- a/merge-recursive.c +++ b/merge-recursive.c @@ -477,9 +477,9 @@ static char *unique_path(const char *pat char *newpath = xmalloc(strlen(path) + 1 + strlen(branch) + 8 + 1); int suffix = 0; struct stat st; - char *p = newpath + strlen(newpath); + char *p = newpath + strlen(path); strcpy(newpath, path); - strcat(newpath, "~"); + *(p++) = '~'; strcpy(p, branch); for (; *p; ++p) if ('/' == *p) -- 1.4.2.rc2.geb7f ```