# [PATCH] Fix http-fetch 1 messages from 2006-07-29 to 2006-07-29. Participants: Johannes Schindelin. Thread: https://gitlist.dev/t/5033 ## Johannes Schindelin, 2006-07-29 00:10 Subject: [PATCH] Fix http-fetch Message-ID: URL: https://gitlist.dev/e/Pine.LNX.4.63.0607290208580.29667%40wbgn013.biozentrum.uni-wuerzburg.de ``` With the latest changes in fetch.c, http-fetch crashed accessing write_ref[i], where write_ref was NULL. Signed-off-by: Johannes Schindelin --- fetch.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fetch.c b/fetch.c index 2151c7b..aeb6bf2 100644 --- a/fetch.c +++ b/fetch.c @@ -245,7 +245,7 @@ void pull_targets_free(int targets, char { while (targets--) { free(target[targets]); - if (write_ref[targets]) + if (write_ref && write_ref[targets]) free((char *) write_ref[targets]); } } @@ -263,7 +263,7 @@ int pull(int targets, char **target, con track_object_refs = 0; for (i = 0; i < targets; i++) { - if (!write_ref[i]) + if (!write_ref || !write_ref[i]) continue; lock[i] = lock_ref_sha1(write_ref[i], NULL, 0); @@ -295,7 +295,7 @@ int pull(int targets, char **target, con msg = NULL; } for (i = 0; i < targets; i++) { - if (!write_ref[i]) + if (!write_ref || !write_ref[i]) continue; ret = write_ref_sha1(lock[i], &sha1[20 * i], msg ? msg : "fetch (unknown)"); lock[i] = NULL; -- 1.4.2.rc2.g0d86-dirty ```