threads / patch / 50212

patch, 2 partsgit-p4: handle moved files when updating a P4 shelve

Subject: [PATCH 0/2] git-p4: handle moved files when updating a P4 shelve

## tl;dr

6 messages between Jan 13, 2019 and Jan 14, 2019. Diffs are folded; open one to read it.

replies: 5people: 3as markdown or json

Luke Diamand· Jan 13, 2019, 13:58 UTC · lore

I found this bug recently in git-p4 - updating a shelved changelist where files are being moved doesn't work. The destination of any moves needs to be added to the list of files passed to P4.

Luke Diamand (2):
  git-p4: add failing test for shelved CL update involving move
  git-p4: handle update of moved files when updating a shelve

 git-p4.py                |  1 +
 t/t9807-git-p4-submit.sh | 53 +++++++++++++++++++++++++++++++++++++---
 2 files changed, 51 insertions(+), 3 deletions(-)

-- 
2.20.1.100.g9ee79a14a8

Luke Diamand· Jan 13, 2019, 13:58 UTC · re: Luke Diamand · lore

[PATCH 1/2] git-p4: add failing test for shelved CL update involving move

Updating a shelved P4 changelist where one or more of the files have been moved does not work. Add a test for this.

Signed-off-by: Luke Diamand <luke@diamand.org>
---
 t/t9807-git-p4-submit.sh | 53 +++++++++++++++++++++++++++++++++++++---
 1 file changed, 50 insertions(+), 3 deletions(-)

Show changes to t/t9807-git-p4-submit.sh +50 −3

diff --git a/t/t9807-git-p4-submit.sh b/t/t9807-git-p4-submit.sh
index 2325599ee6..08dc8d2caf 100755
--- a/t/t9807-git-p4-submit.sh
+++ b/t/t9807-git-p4-submit.sh
@@ -500,6 +500,12 @@ test_expect_success 'submit --shelve' '
 	)
 '
 
+last_shelve() {
+	change=$(p4 -G changes -s shelved -m 1 //depot/... | \
+		marshal_dump change)
+	echo $change
+}
+
 make_shelved_cl() {
 	test_commit "$1" >/dev/null &&
 	git p4 submit --origin HEAD^ --shelve >/dev/null &&
@@ -533,12 +539,53 @@ test_expect_success 'submit --update-shelve' '
 	) &&
 	(
 		cd "$cli" &&
-		change=$(p4 -G changes -s shelved -m 1 //depot/... | \
-			 marshal_dump change) &&
+		change=$(last_shelve) &&
 		p4 unshelve -c $change -s $change &&
 		grep -q updated-line shelf.t &&
 		p4 describe -S $change | grep added-file.t &&
-		test_path_is_missing shelved-change-1.t
+		test_path_is_missing shelved-change-1.t &&
+		p4 revert ...
+	)
+'
+
+test_expect_failure 'update a shelve involving a moved file' '
+	test_when_finished cleanup_git &&
+	(
+		cd "$cli" &&
+		: >file_to_move &&
+		p4 add file_to_move &&
+		p4 submit -d "change1" &&
+		p4 edit file_to_move &&
+		echo change >>file_to_move &&
+		p4 submit -d "change2" &&
+		p4 opened
+	) &&
+	git p4 clone --dest="$git" //depot &&
+	(
+		cd "$git" &&
+		git config git-p4.skipSubmitEdit true &&
+		mkdir moved &&
+		git mv file_to_move moved/ &&
+		git commit -m "rename a file" &&
+		git p4 submit -M --shelve --origin HEAD^ &&
+		: >new_file &&
+		git add new_file &&
+		git commit --amend &&
+		git show --stat HEAD &&
+		change=$(last_shelve) &&
+		git p4 submit -M --update-shelve $change --commit HEAD
+	) &&
+	(
+		cd "$cli" &&
+		change=$(last_shelve) &&
+		echo change=$change &&
+		p4 unshelve -s $change &&
+		p4 submit -d "Testing update-shelve" &&
+		test_path_is_file moved/file_to_move &&
+		test_path_is_missing file_to_move &&
+		test_path_is_file new_file &&
+		echo "unshelved and submitted change $change" &&
+		p4 changes moved/file_to_move | grep "Testing update-shelve"
 	)
 '

-- 
2.20.1.100.g9ee79a14a8

Luke Diamand· Jan 13, 2019, 13:58 UTC · re: Luke Diamand · lore

[PATCH 2/2] git-p4: handle update of moved files when updating a shelve

Perforce requires a complete list of files being operated on. If git is updating an existing shelved changelist, then any files which are moved were not being added to this list.

Signed-off-by: Luke Diamand <luke@diamand.org>
---
 git-p4.py                | 1 +
 t/t9807-git-p4-submit.sh | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

Show changes to 2 files +2 −1

git-p4.py, t/t9807-git-p4-submit.sh

diff --git a/git-p4.py b/git-p4.py
index 1998c3e141..20c5ce9903 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -1875,6 +1875,7 @@ def applyCommit(self, id):
                 editedFiles.add(dest)
             elif modifier == "R":
                 src, dest = diff['src'], diff['dst']
+                all_files.append(dest)
                 if self.p4HasMoveCommand:
                     p4_edit(src)        # src must be open before move
                     p4_move(src, dest)  # opens for (move/delete, move/add)
diff --git a/t/t9807-git-p4-submit.sh b/t/t9807-git-p4-submit.sh
index 08dc8d2caf..4d5ea9e64c 100755
--- a/t/t9807-git-p4-submit.sh
+++ b/t/t9807-git-p4-submit.sh
@@ -548,7 +548,7 @@ test_expect_success 'submit --update-shelve' '
 	)
 '
 
-test_expect_failure 'update a shelve involving a moved file' '
+test_expect_success 'update a shelve involving a moved file' '
 	test_when_finished cleanup_git &&
 	(
 		cd "$cli" &&

-- 
2.20.1.100.g9ee79a14a8

Eric Sunshine· Jan 13, 2019, 21:57 UTC · re: Luke Diamand · lore

Re: [PATCH 1/2] git-p4: add failing test for shelved CL update involving move

On Sun, Jan 13, 2019 at 8:58 AM Luke Diamand <luke@diamand.org> wrote:

> Updating a shelved P4 changelist where one or more of the files have
> been moved does not work. Add a test for this.

Perhaps this message could give more detail about the actual problem than the generic "does not work" which provides no useful information.

Show 9 quoted lines

> Signed-off-by: Luke Diamand <luke@diamand.org>
> ---
> diff --git a/t/t9807-git-p4-submit.sh b/t/t9807-git-p4-submit.sh
> @@ -500,6 +500,12 @@ test_expect_success 'submit --shelve' '
> +last_shelve() {
> +       change=$(p4 -G changes -s shelved -m 1 //depot/... | \
> +               marshal_dump change)
> +       echo $change
> +}

A simpler definition for this function would be:

last_shelve () {
    p4 -G changes -s shelved -m 1 //depot/... | marshal_dump change
}

which will give the same result when you later capture its output with:

    change=$(last_shelve) &&

Show 15 quoted lines

> @@ -533,12 +539,53 @@ test_expect_success 'submit --update-shelve' '
>         ) &&
>         (
>                 cd "$cli" &&
> -               change=$(p4 -G changes -s shelved -m 1 //depot/... | \
> -                        marshal_dump change) &&
> +               change=$(last_shelve) &&
>                 p4 unshelve -c $change -s $change &&
>                 grep -q updated-line shelf.t &&
>                 p4 describe -S $change | grep added-file.t &&
> -               test_path_is_missing shelved-change-1.t
> +               test_path_is_missing shelved-change-1.t &&
> +               p4 revert ...
> +       )
> +'

Junio C Hamano· Jan 14, 2019, 19:03 UTC · re: Eric Sunshine · lore

Re: [PATCH 1/2] git-p4: add failing test for shelved CL update involving move

Eric Sunshine <sunshine@sunshineco.com> writes:

Show 22 quoted lines

> On Sun, Jan 13, 2019 at 8:58 AM Luke Diamand <luke@diamand.org> wrote:
>> Updating a shelved P4 changelist where one or more of the files have
>> been moved does not work. Add a test for this.
>
> Perhaps this message could give more detail about the actual problem
> than the generic "does not work" which provides no useful information.
>
>> Signed-off-by: Luke Diamand <luke@diamand.org>
>> ---
>> diff --git a/t/t9807-git-p4-submit.sh b/t/t9807-git-p4-submit.sh
>> @@ -500,6 +500,12 @@ test_expect_success 'submit --shelve' '
>> +last_shelve() {
>> +       change=$(p4 -G changes -s shelved -m 1 //depot/... | \
>> +               marshal_dump change)
>> +       echo $change
>> +}
>
> A simpler definition for this function would be:
>
> last_shelve () {
>     p4 -G changes -s shelved -m 1 //depot/... | marshal_dump change
> }

Indeed, and it will work better even when the output from marshal_dump has $IFS and other traits that do not survive "echo $change" intact.

Junio C Hamano· Jan 14, 2019, 18:56 UTC · re: Luke Diamand · lore

Re: [PATCH 0/2] git-p4: handle moved files when updating a P4 shelve

Luke Diamand <luke@diamand.org> writes:

> I found this bug recently in git-p4 - updating a shelved changelist where files
> are being moved doesn't work. The destination of any moves needs to be
> added to the list of files passed to P4.

Thanks.

Show 8 quoted lines

>
> Luke Diamand (2):
>   git-p4: add failing test for shelved CL update involving move
>   git-p4: handle update of moved files when updating a shelve
>
>  git-p4.py                |  1 +
>  t/t9807-git-p4-submit.sh | 53 +++++++++++++++++++++++++++++++++++++---
>  2 files changed, 51 insertions(+), 3 deletions(-)