# [PATCH] fetch: fix extensions.partialclone name in error message

2 messages from 2019-01-13 to 2019-01-13. Participants: Christian Couder, Eric Sunshine.
Thread: https://gitlist.dev/t/50211

## Christian Couder, 2019-01-13 08:52

Subject: [PATCH] fetch: fix extensions.partialclone name in error message
Message-ID: <20190113085219.22993-1-chriscool@tuxfamily.org>
URL: https://gitlist.dev/e/20190113085219.22993-1-chriscool%40tuxfamily.org

```
There is "extensions.partialclone" and "core.partialCloneFilter", but
not "core.partialclone". Only "extensions.partialclone" is meant to
contain a remote name.

While at it, let's wrap the relevant code lines to keep them at a
reasonable lenght.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 builtin/fetch.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/builtin/fetch.c b/builtin/fetch.c
index e0140327aa..c0ade48f5d 100644
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -1478,7 +1478,8 @@ static inline void fetch_one_setup_partial(struct remote *remote)
 	 */
 	if (strcmp(remote->name, repository_format_partial_clone)) {
 		if (filter_options.choice)
-			die(_("--filter can only be used with the remote configured in core.partialClone"));
+			die(_("--filter can only be used with the remote "
+			      "configured in extensions.partialclone"));
 		return;
 	}
 
@@ -1646,7 +1647,8 @@ int cmd_fetch(int argc, const char **argv, const char *prefix)
 		result = fetch_one(remote, argc, argv, prune_tags_ok);
 	} else {
 		if (filter_options.choice)
-			die(_("--filter can only be used with the remote configured in core.partialClone"));
+			die(_("--filter can only be used with the remote "
+			      "configured in extensions.partialclone"));
 		/* TODO should this also die if we have a previous partial-clone? */
 		result = fetch_multiple(&list);
 	}
-- 
2.20.1.122.g9a13c7f8ea.dirty


```

## Eric Sunshine, 2019-01-13 09:02

Subject: Re: [PATCH] fetch: fix extensions.partialclone name in error message
Message-ID: <CAPig+cQ+Wjif5R4gxXCcOO7ctwU-m190E6q5xi8tWLpC6JJgfA@mail.gmail.com>
URL: https://gitlist.dev/e/CAPig%2BcQ%2BWjif5R4gxXCcOO7ctwU-m190E6q5xi8tWLpC6JJgfA%40mail.gmail.com
In-Reply-To: <20190113085219.22993-1-chriscool@tuxfamily.org>

```
On Sun, Jan 13, 2019 at 3:52 AM Christian Couder
<christian.couder@gmail.com> wrote:
> There is "extensions.partialclone" and "core.partialCloneFilter", but
> not "core.partialclone". Only "extensions.partialclone" is meant to
> contain a remote name.
>
> While at it, let's wrap the relevant code lines to keep them at a
> reasonable lenght.

s/lenght/length/

> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>

```
