threads / discuss / 50027

Pre-commit hook does not work properly in recent version

Subject: Pre-commit hook does not work properly in recent version

## tl;dr

2 messages between Dec 13, 2018 and Dec 13, 2018.

replies: 1people: 2as markdown or json

Andrew Kharchenko· Dec 13, 2018, 15:03 UTC · lore

Hello,

I found a bug in Git v. 2.20.0 and 2.19.x at least, where pre-commit hook does not work properly.

OS: macOS High Sierra
Git: 2.20.0, 2.19.x

Description: pre-commit file should be marked as executable in order to recreate the bug. When executing “git commit”, it silently exits without any message.
It was found, that Git version 2.17.1 still works as expected.

— Sincerely, Andrew Kharchenko

Johannes Schindelin· Dec 13, 2018, 19:19 UTC · re: Andrew Kharchenko · lore

Re: Pre-commit hook does not work properly in recent version

Hi Andrew,

On Thu, 13 Dec 2018, Andrew Kharchenko wrote:

Show 7 quoted lines

> I found a bug in Git v. 2.20.0 and 2.19.x at least, where pre-commit hook does not work properly.
> 
> OS: macOS High Sierra
> Git: 2.20.0, 2.19.x
> 
> Description: pre-commit file should be marked as executable in order to recreate the bug. When executing “git commit”, it silently exits without any message.
> It was found, that Git version 2.17.1 still works as expected.

Have you dug deeper? Like, add a `set -x` at the beginning of that hook to find out why it is exiting early?

Ciao, Johannes