threads / patch / 49933

patch, 2 partsconfig.mak.uname: OpenBSD uses BSD semantics with fread for directories

Subject: [PATCH 1/2] config.mak.uname: OpenBSD uses BSD semantics with fread for directories

## tl;dr

2 messages between Dec 2, 2018 and Dec 2, 2018. Diffs are folded; open one to read it.

replies: 1people: 1as markdown or json

Carlo Marcelo Arenas Belón· Dec 2, 2018, 02:43 UTC · lore
this "fixes" test 23 (proper error on directory "files") from t1308

MirBSD likely also affected but this was only tested with OpenBSD and therefore this specific change only affects that platform

the optional 'configure' sets this automatically (tested with 6.1 to 6.4) but considering this is a legacy feature it is likely that it affected all old versions and is probably what most users had been using as a workaround

Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
---
 config.mak.uname | 1 +
 1 file changed, 1 insertion(+)
Show changes to config.mak.uname +1 −0
diff --git a/config.mak.uname b/config.mak.uname
index 3ee7da0e23..378ca0a582 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -233,6 +233,7 @@ ifeq ($(uname_S),OpenBSD)
 	HAVE_BSD_SYSCTL = YesPlease
 	HAVE_BSD_KERN_PROC_SYSCTL = YesPlease
 	PROCFS_EXECUTABLE_PATH = /proc/curproc/file
+	FREAD_READS_DIRECTORIES = UnfortunatelyYes
 endif
 ifeq ($(uname_S),MirBSD)
 	NO_STRCASESTR = YesPlease
-- 
2.20.0.rc2
Carlo Arenas· Dec 2, 2018, 02:51 UTC · re: Carlo Marcelo Arenas Belón · lore

Re: [PATCH 1/2] config.mak.uname: OpenBSD uses BSD semantics with fread for directories

FWIW this patch doesn't have any other siblings and subject should had been just [PATCH]; apologize for the confusion and the spam (including that other duplicated email, and most likely this one)

Carlo

← back to recent threads