# [PATCH] transport-helper.c: do not translate a string twice 2 messages from 2018-11-26 to 2018-11-29. Participants: Nguyễn Thái Ngọc Duy, Junio C Hamano. Thread: https://gitlist.dev/t/49894 ## Nguyễn Thái Ngọc Duy, 2018-11-26 19:57 Subject: [PATCH] transport-helper.c: do not translate a string twice Message-ID: <20181126195756.15537-1-pclouds@gmail.com> URL: https://gitlist.dev/e/20181126195756.15537-1-pclouds%40gmail.com ``` Signed-off-by: Nguyễn Thái Ngọc Duy --- My bad. transport-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/transport-helper.c b/transport-helper.c index 7213fa0d32..bf225c698f 100644 --- a/transport-helper.c +++ b/transport-helper.c @@ -573,7 +573,7 @@ static int run_connect(struct transport *transport, struct strbuf *cmdbuf) fprintf(stderr, "Debug: Falling back to dumb " "transport.\n"); } else { - die(_(_("unknown response to connect: %s")), + die(_("unknown response to connect: %s"), cmdbuf->buf); } -- 2.19.1.1327.g328c130451.dirty ``` ## Junio C Hamano, 2018-11-29 06:30 Subject: Re: [PATCH] transport-helper.c: do not translate a string twice Message-ID: URL: https://gitlist.dev/e/xmqqo9a8o0op.fsf%40gitster-ct.c.googlers.com In-Reply-To: <20181126195756.15537-1-pclouds@gmail.com> ``` Nguyễn Thái Ngọc Duy writes: > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > My bad. > > transport-helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/transport-helper.c b/transport-helper.c > index 7213fa0d32..bf225c698f 100644 > --- a/transport-helper.c > +++ b/transport-helper.c > @@ -573,7 +573,7 @@ static int run_connect(struct transport *transport, struct strbuf *cmdbuf) > fprintf(stderr, "Debug: Falling back to dumb " > "transport.\n"); > } else { > - die(_(_("unknown response to connect: %s")), > + die(_("unknown response to connect: %s"), > cmdbuf->buf); Thanks. ```