# [PATCH 0/1] mingw: use CreateHardLink() directly 2 messages from 2018-11-13 to 2018-11-13. Participants: Johannes Schindelin via GitGitGadget. Thread: https://gitlist.dev/t/49818 ## Johannes Schindelin via GitGitGadget, 2018-11-13 14:37 Subject: [PATCH 0/1] mingw: use CreateHardLink() directly Message-ID: URL: https://gitlist.dev/e/pull.77.git.gitgitgadget%40gmail.com ``` This is another tidbit from the stash of Git for Windows' patches: it avoids loading the function address of CreateHardLink() at runtime. This was done in case we were running on a Windows version that does not support that function, but we no longer support any of these Windows versions. Johannes Schindelin (1): mingw: use `CreateHardLink()` directly compat/mingw.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) base-commit: 8858448bb49332d353febc078ce4a3abcc962efe Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-77%2Fdscho%2Fmingw-CreateHardLink-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-77/dscho/mingw-CreateHardLink-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/77 -- gitgitgadget ``` ## Johannes Schindelin via GitGitGadget, 2018-11-13 14:37 Subject: [PATCH 1/1] mingw: use `CreateHardLink()` directly Message-ID: URL: https://gitlist.dev/e/b1fdce037c66b0dcfc36f7a8b0e231880962ccf4.1542119819.git.gitgitgadget%40gmail.com In-Reply-To: ``` From: Johannes Schindelin The function `CreateHardLink()` is available in all supported Windows versions (even since Windows XP), so there is no more need to resolve it at runtime. Helped-by: Max Kirillov Signed-off-by: Johannes Schindelin --- compat/mingw.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/compat/mingw.c b/compat/mingw.c index 3b44dd99d7..fdcf946275 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -2084,24 +2084,12 @@ int mingw_raise(int sig) int link(const char *oldpath, const char *newpath) { - typedef BOOL (WINAPI *T)(LPCWSTR, LPCWSTR, LPSECURITY_ATTRIBUTES); - static T create_hard_link = NULL; wchar_t woldpath[MAX_PATH], wnewpath[MAX_PATH]; if (xutftowcs_path(woldpath, oldpath) < 0 || xutftowcs_path(wnewpath, newpath) < 0) return -1; - if (!create_hard_link) { - create_hard_link = (T) GetProcAddress( - GetModuleHandle("kernel32.dll"), "CreateHardLinkW"); - if (!create_hard_link) - create_hard_link = (T)-1; - } - if (create_hard_link == (T)-1) { - errno = ENOSYS; - return -1; - } - if (!create_hard_link(wnewpath, woldpath, NULL)) { + if (!CreateHardLinkW(wnewpath, woldpath, NULL)) { errno = err_win_to_posix(GetLastError()); return -1; } -- gitgitgadget ```