# [PATCH 0/1] Load system libraries the recommended way on Windows 2 messages from 2018-10-23 to 2018-10-23. Participants: Johannes Schindelin via GitGitGadget. Thread: https://gitlist.dev/t/49647 ## Johannes Schindelin via GitGitGadget, 2018-10-23 10:51 Subject: [PATCH 0/1] Load system libraries the recommended way on Windows Message-ID: URL: https://gitlist.dev/e/pull.55.git.gitgitgadget%40gmail.com ``` The search order for DLLs on Windows is a bit funny, and for system libraries, it is recommended to use a strict search path. In practice, this should not make a difference, as the library has been loaded into memory already, and therefore the LoadLibrary() call would just return the handle instead of loading the library again. Johannes Schindelin (1): mingw: load system libraries the recommended way compat/mingw.c | 3 ++- contrib/credential/wincred/git-credential-wincred.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) base-commit: c4df23f7927d8d00e666a3c8d1b3375f1dc8a3c1 Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-55%2Fdscho%2Fmingw-load-sys-dll-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-55/dscho/mingw-load-sys-dll-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/55 -- gitgitgadget ``` ## Johannes Schindelin via GitGitGadget, 2018-10-23 10:51 Subject: [PATCH 1/1] mingw: load system libraries the recommended way Message-ID: <89887345376ccf8813603f10ac51d39527397aee.1540291906.git.gitgitgadget@gmail.com> URL: https://gitlist.dev/e/89887345376ccf8813603f10ac51d39527397aee.1540291906.git.gitgitgadget%40gmail.com In-Reply-To: ``` From: Johannes Schindelin When we access IPv6-related functions, we load the corresponding system library using the `LoadLibrary()` function, which is not the recommended way to load system libraries. In practice, it does not make a difference: the `ws2_32.dll` library containing the IPv6 functions is already loaded into memory, so LoadLibrary() simply reuses the already-loaded library. Still, recommended way is recommended way, so let's use that instead. While at it, also adjust the code in contrib/ that loads system libraries. Signed-off-by: Johannes Schindelin --- compat/mingw.c | 3 ++- contrib/credential/wincred/git-credential-wincred.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/compat/mingw.c b/compat/mingw.c index 18caf2196..9fd7db571 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -1577,7 +1577,8 @@ static void ensure_socket_initialization(void) WSAGetLastError()); for (name = libraries; *name; name++) { - ipv6_dll = LoadLibrary(*name); + ipv6_dll = LoadLibraryExA(*name, NULL, + LOAD_LIBRARY_SEARCH_SYSTEM32); if (!ipv6_dll) continue; diff --git a/contrib/credential/wincred/git-credential-wincred.c b/contrib/credential/wincred/git-credential-wincred.c index 86518cd93..5bdad41de 100644 --- a/contrib/credential/wincred/git-credential-wincred.c +++ b/contrib/credential/wincred/git-credential-wincred.c @@ -75,7 +75,8 @@ static CredDeleteWT CredDeleteW; static void load_cred_funcs(void) { /* load DLLs */ - advapi = LoadLibrary("advapi32.dll"); + advapi = LoadLibraryExA("advapi32.dll", NULL, + LOAD_LIBRARY_SEARCH_SYSTEM32); if (!advapi) die("failed to load advapi32.dll"); -- gitgitgadget ```