# [PATCH] multi-pack-index: avoid dead store for struct progress 4 messages from 2018-10-18 to 2018-10-19. Participants: Carlo Marcelo Arenas Belón, Derrick Stolee, Carlo Arenas, Junio C Hamano. Thread: https://gitlist.dev/t/49609 ## Carlo Marcelo Arenas Belón, 2018-10-18 18:59 Subject: [PATCH] multi-pack-index: avoid dead store for struct progress Message-ID: <20181018185920.22975-1-carenas@gmail.com> URL: https://gitlist.dev/e/20181018185920.22975-1-carenas%40gmail.com ``` it is initialized unconditionally by a call to start_progress below. Signed-off-by: Carlo Marcelo Arenas Belón --- midx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/midx.c b/midx.c index ea2f3ffe2e..4fac0cd08a 100644 --- a/midx.c +++ b/midx.c @@ -941,7 +941,7 @@ static void midx_report(const char *fmt, ...) int verify_midx_file(const char *object_dir) { uint32_t i; - struct progress *progress = NULL; + struct progress *progress; struct multi_pack_index *m = load_multi_pack_index(object_dir, 1); verify_midx_error = 0; -- 2.19.1 ``` ## Derrick Stolee, 2018-10-18 19:36 Subject: Re: [PATCH] multi-pack-index: avoid dead store for struct progress Message-ID: <16e462a7-cdd6-9d5d-d740-d5241485787b@gmail.com> URL: https://gitlist.dev/e/16e462a7-cdd6-9d5d-d740-d5241485787b%40gmail.com In-Reply-To: <20181018185920.22975-1-carenas@gmail.com> ``` On 10/18/2018 2:59 PM, Carlo Marcelo Arenas Belón wrote: > it is initialized unconditionally by a call to start_progress > below. > > Signed-off-by: Carlo Marcelo Arenas Belón > --- > midx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/midx.c b/midx.c > index ea2f3ffe2e..4fac0cd08a 100644 > --- a/midx.c > +++ b/midx.c > @@ -941,7 +941,7 @@ static void midx_report(const char *fmt, ...) > int verify_midx_file(const char *object_dir) > { > uint32_t i; > - struct progress *progress = NULL; > + struct progress *progress; > struct multi_pack_index *m = load_multi_pack_index(object_dir, 1); > verify_midx_error = 0; > This makes sense as a cleanup. Is there a tool that reports a wasted initialization that you used to find this? -Stolee ``` ## Carlo Arenas, 2018-10-18 19:56 Subject: Re: [PATCH] multi-pack-index: avoid dead store for struct progress Message-ID: URL: https://gitlist.dev/e/CAPUEspixnjOm7YAuCgCTfmWf28kF8jCACD%3D-VHNDAeL2Gu8mQQ%40mail.gmail.com In-Reply-To: <16e462a7-cdd6-9d5d-d740-d5241485787b@gmail.com> ``` On Thu, Oct 18, 2018 at 12:36 PM Derrick Stolee wrote: > > Is there a tool that reports a wasted > initialization that you used to find this? I'd used clang's analyzer recently to track a similar issue before in a different codebase, but not for this specific case. Carlo ``` ## Junio C Hamano, 2018-10-19 02:26 Subject: Re: [PATCH] multi-pack-index: avoid dead store for struct progress Message-ID: URL: https://gitlist.dev/e/xmqqr2gm3c4v.fsf%40gitster-ct.c.googlers.com In-Reply-To: <20181018185920.22975-1-carenas@gmail.com> ``` Carlo Marcelo Arenas Belón writes: > it is initialized unconditionally by a call to start_progress > below. > > Signed-off-by: Carlo Marcelo Arenas Belón > --- > midx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/midx.c b/midx.c > index ea2f3ffe2e..4fac0cd08a 100644 > --- a/midx.c > +++ b/midx.c > @@ -941,7 +941,7 @@ static void midx_report(const char *fmt, ...) > int verify_midx_file(const char *object_dir) > { > uint32_t i; > - struct progress *progress = NULL; > + struct progress *progress; > struct multi_pack_index *m = load_multi_pack_index(object_dir, 1); > verify_midx_error = 0; Both changes make sense. It's kind of surprising that this still matters, though; I would have expected a compiler would notice. ```