# [PATCH 1/2] Doc: use `--type=bool` instead of `--bool` 4 messages from 2018-09-19 to 2018-09-19. Participants: Martin Ågren, Taylor Blau. Thread: https://gitlist.dev/t/49384 ## Martin Ågren, 2018-09-19 16:38 Subject: [PATCH 1/2] Doc: use `--type=bool` instead of `--bool` Message-ID: URL: https://gitlist.dev/e/e81bbd0e714221aac47b387e7d1e1572af32aa8f.1537375024.git.martin.agren%40gmail.com ``` After fb0dc3bac1 (builtin/config.c: support `--type=` as preferred alias for `--`, 2018-04-18) we have a more modern way of spelling `--bool`. Update all instances except those that explicitly document the "historical options" in git-config.txt. The other old-style type-specifiers already seem to be gone except for in that list of historical options. Tweak the grammar a little in config.txt while we are there. Signed-off-by: Martin Ågren --- Documentation/config.txt | 2 +- Documentation/git-config.txt | 4 ++-- Documentation/git.txt | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/config.txt b/Documentation/config.txt index 112041f407..088cbefecc 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt @@ -225,7 +225,7 @@ boolean:: false;; Boolean false literals are `no`, `off`, `false`, `0` and the empty string. + -When converting value to the canonical form using `--bool` type +When converting a value to its canonical form using the `--type=bool` type specifier, 'git config' will ensure that the output is "true" or "false" (spelled in lowercase). diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt index 8e240435be..9d8cea72dd 100644 --- a/Documentation/git-config.txt +++ b/Documentation/git-config.txt @@ -442,9 +442,9 @@ For URLs in `https://weak.example.com`, `http.sslVerify` is set to false, while it is set to `true` for all others: ------------ -% git config --bool --get-urlmatch http.sslverify https://good.example.com +% git config --type=bool --get-urlmatch http.sslverify https://good.example.com true -% git config --bool --get-urlmatch http.sslverify https://weak.example.com +% git config --type=bool --get-urlmatch http.sslverify https://weak.example.com false % git config --get-urlmatch http https://weak.example.com http.cookieFile /tmp/cookie.txt diff --git a/Documentation/git.txt b/Documentation/git.txt index 74a9d7edb4..08e533d62b 100644 --- a/Documentation/git.txt +++ b/Documentation/git.txt @@ -76,7 +76,7 @@ Note that omitting the `=` in `git -c foo.bar ...` is allowed and sets `foo.bar` to the boolean true value (just like `[foo]bar` would in a config file). Including the equals but with an empty value (like `git -c foo.bar= ...`) sets `foo.bar` to the empty string which `git config ---bool` will convert to `false`. +--type=bool` will convert to `false`. --exec-path[=]:: Path to wherever your core Git programs are installed. -- 2.19.0.216.g2d3b1c576c ``` ## Martin Ågren, 2018-09-19 16:38 Subject: [PATCH 2/2] git-config.txt: fix 'see: above' note Message-ID: <377b7cfa36c3b23150005f7faec02bbc4a325bd7.1537375024.git.martin.agren@gmail.com> URL: https://gitlist.dev/e/377b7cfa36c3b23150005f7faec02bbc4a325bd7.1537375024.git.martin.agren%40gmail.com In-Reply-To: ``` Rather than saying "(see: above)", drop the colon. Also drop the comma before this note. Signed-off-by: Martin Ågren --- Documentation/git-config.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt index 9d8cea72dd..5e87d82933 100644 --- a/Documentation/git-config.txt +++ b/Documentation/git-config.txt @@ -188,8 +188,8 @@ Valid ``'s include: --bool-or-int:: --path:: --expiry-date:: - Historical options for selecting a type specifier. Prefer instead `--type`, - (see: above). + Historical options for selecting a type specifier. Prefer instead `--type` + (see above). --no-type:: Un-sets the previously set type specifier (if one was previously set). This -- 2.19.0.216.g2d3b1c576c ``` ## Taylor Blau, 2018-09-19 17:21 Subject: Re: [PATCH 2/2] git-config.txt: fix 'see: above' note Message-ID: <20180919172143.GA60492@syl> URL: https://gitlist.dev/e/20180919172143.GA60492%40syl In-Reply-To: <377b7cfa36c3b23150005f7faec02bbc4a325bd7.1537375024.git.martin.agren@gmail.com> ``` Hi Martin, On Wed, Sep 19, 2018 at 06:38:19PM +0200, Martin Ågren wrote: > Rather than saying "(see: above)", drop the colon. Also drop the comma > before this note. > > Signed-off-by: Martin Ågren Thanks for both of these. I should have at least taken care of 1/2 myself, but I am appreciative of you doing it, too :-). I could take or leave 2/2, since I usually write ", (see: above)", but I'm not sure if that's grammatically correct or not. But, either approach is fine with me, so both of these have my: Reviewed-by: Taylor Blau Thanks, Taylor ``` ## Martin Ågren, 2018-09-19 17:55 Subject: Re: [PATCH 2/2] git-config.txt: fix 'see: above' note Message-ID: URL: https://gitlist.dev/e/CAN0heSq7T%3Dt7A9_jzTmNvj8SEfS0E6xWs-SFFwZjb2U1Ryqd2w%40mail.gmail.com In-Reply-To: <20180919172143.GA60492@syl> ``` Hi Taylor, On Wed, 19 Sep 2018 at 19:21, Taylor Blau wrote: > I could take or leave 2/2, since I usually write ", (see: above)", but > I'm not sure if that's grammatically correct or not. Well, I sure ain't no grammar expert too... This is not a patch I feel strongly about, so I'll be happy to defer to others. Thanks for reviewing, Martin ```