# [PATCH] Display "gitweb/test/file with spaces" in gitk

2 messages from 2006-07-20 to 2006-07-21. Participants: Thomas Kolejka, Paul Mackerras.
Thread: https://gitlist.dev/t/4926

## Thomas Kolejka, 2006-07-20 10:12

Subject: [PATCH] Display "gitweb/test/file with spaces" in gitk
Message-ID: <20060720101223.116320@gmx.net>
URL: https://gitlist.dev/e/20060720101223.116320%40gmx.net

```
Hello,

with this patch files with spaces in their names are displayed
in the treeview of gitk.

I use git to make a "backup"/"dump" of a DOS-FS .. and there are 
those filenames ;-).

Take care .. it's my first tcl hack!

Thomas

--
diff --git a/gitk b/gitk
index ba4644f..93af19c 100755
--- a/gitk
+++ b/gitk
@@ -3938,7 +3938,7 @@ proc gettreeline {gtf id} {
     while {[gets $gtf line] >= 0} {
        if {[lindex $line 1] ne "blob"} continue
        set sha1 [lindex $line 2]
-       set fname [lindex $line 3]
+       set fname [join [lrange $line 3 end]]
        lappend treefilelist($id) $fname
        lappend treeidlist($id) $sha1
     }
@@ -4147,7 +4147,7 @@ proc gettreediffline {gdtf ids} {
        }
        return
     }
-    set file [lindex $line 5]
+    set file [join [lrange $line 5 end]]
     lappend treediff $file
 }



-- 


Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen!
Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer

```

## Paul Mackerras, 2006-07-21 13:01

Subject: Re: [PATCH] Display "gitweb/test/file with spaces" in gitk
Message-ID: <17600.53316.193618.755468@cargo.ozlabs.ibm.com>
URL: https://gitlist.dev/e/17600.53316.193618.755468%40cargo.ozlabs.ibm.com
In-Reply-To: <20060720101223.116320@gmx.net>

```
Thomas Kolejka writes:

> with this patch files with spaces in their names are displayed
> in the treeview of gitk.
> 
> I use git to make a "backup"/"dump" of a DOS-FS .. and there are 
> those filenames ;-).

Hmmm, certainly my code is incorrect.  However with your code, tabs in
the filename will get changed to spaces.  Treating the line read from
git-ls-tree or git-diff-tree was a shortcut hack that isn't really
optimal.  I'll think about the best way to fix it.

Paul.

```