# [PATCH] commit: use timestamp_t for author_date_slab 2 messages from 2018-08-21 to 2018-08-21. Participants: Derrick Stolee, Junio C Hamano. Thread: https://gitlist.dev/t/49181 ## Derrick Stolee, 2018-08-21 20:54 Subject: [PATCH] commit: use timestamp_t for author_date_slab Message-ID: <20180821205359.29569-1-dstolee@microsoft.com> URL: https://gitlist.dev/e/20180821205359.29569-1-dstolee%40microsoft.com ``` The author_date_slab is used to store the author date of a commit when walking with the --author-date flag in rev-list or log. This was added as an 'unsigned long' in 81c6b38b "log: --author-date-order" Since 'unsigned long' is ambiguous in its bit-ness across platforms (64-bit in Linux, 32-bit in Windows, for example), most references to the author dates in commit.c were converted to timestamp_t in dddbad72 "timestamp_t: a new data type for timestamps" However, the slab definition was missed, leading to a mismatch in the data types in Windows. This would not reveal itself as a bug unless someone authors a commit after February 2106, but commits can store anything as their author date. Signed-off-by: Derrick Stolee --- I found this while reading up on the revision-walk machinery. This code hasn't been touched in years, so could apply to 'maint'. commit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/commit.c b/commit.c index 0030e79940..2ce5052b3e 100644 --- a/commit.c +++ b/commit.c @@ -609,7 +609,7 @@ struct commit *pop_commit(struct commit_list **stack) define_commit_slab(indegree_slab, int); /* record author-date for each commit object */ -define_commit_slab(author_date_slab, unsigned long); +define_commit_slab(author_date_slab, timestamp_t); static void record_author_date(struct author_date_slab *author_date, struct commit *commit) -- 2.19.0.rc0 ``` ## Junio C Hamano, 2018-08-21 21:05 Subject: Re: [PATCH] commit: use timestamp_t for author_date_slab Message-ID: URL: https://gitlist.dev/e/xmqqy3cz77n4.fsf%40gitster-ct.c.googlers.com In-Reply-To: <20180821205359.29569-1-dstolee@microsoft.com> ``` Derrick Stolee writes: > The author_date_slab is used to store the author date of a commit > when walking with the --author-date flag in rev-list or log. This > was added as an 'unsigned long' in > > 81c6b38b "log: --author-date-order" > > Since 'unsigned long' is ambiguous in its bit-ness across platforms > (64-bit in Linux, 32-bit in Windows, for example), most references > to the author dates in commit.c were converted to timestamp_t in > > dddbad72 "timestamp_t: a new data type for timestamps" > > However, the slab definition was missed, Makes sense, and obviously correct. > I found this while reading up on the revision-walk machinery. This code > hasn't been touched in years, so could apply to 'maint'. Thanks. ```