# [PATCH] Makefile: add missing dependency for command-list.h

1 messages from 2018-08-06 to 2018-08-06. Participants: Nguyễn Thái Ngọc Duy.
Thread: https://gitlist.dev/t/49048

## Nguyễn Thái Ngọc Duy, 2018-08-06 16:34

Subject: [PATCH] Makefile: add missing dependency for command-list.h
Message-ID: <20180806163421.30636-1-pclouds@gmail.com>
URL: https://gitlist.dev/e/20180806163421.30636-1-pclouds%40gmail.com

```
Commit 3ac68a93fd (help: add --config to list all available config -
2018-05-26) makes generate-cmdlist.sh adds a new input source
config.txt but it's not a Makefile dependency. Any changes in
config.txt will not trigger command-list.h regeneration and the config
list in this file becomes outdated. Correct the dependency.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index bc4fc8eeab..47ca56d0e2 100644
--- a/Makefile
+++ b/Makefile
@@ -2037,7 +2037,7 @@ $(BUILT_INS): git$X
 
 command-list.h: generate-cmdlist.sh command-list.txt
 
-command-list.h: $(wildcard Documentation/git*.txt)
+command-list.h: $(wildcard Documentation/git*.txt) Documentation/config.txt
 	$(QUIET_GEN)$(SHELL_PATH) ./generate-cmdlist.sh command-list.txt >$@+ && mv $@+ $@
 
 SCRIPT_DEFINES = $(SHELL_PATH_SQ):$(DIFF_SQ):$(GIT_VERSION):\
-- 
2.18.0.901.gd528ad0b1c.dirty


```