# [PATCH] mw-to-git/t9360: fix broken &&-chain 6 messages from 2018-07-30 to 2018-08-21. Participants: Eric Sunshine, Jonathan Nieder, Matthieu Moy, Antoine Beaupré. Thread: https://gitlist.dev/t/48984 ## Eric Sunshine, 2018-07-30 20:46 Subject: [PATCH] mw-to-git/t9360: fix broken &&-chain Message-ID: <20180730204646.32312-1-sunshine@sunshineco.com> URL: https://gitlist.dev/e/20180730204646.32312-1-sunshine%40sunshineco.com In-Reply-To: ``` Signed-off-by: Eric Sunshine --- Jonathan's discovery[1] of a broken &&-chain in a contrib/subtree test prompted me to check other tests bundled in contrib/. This was the only other problem found. Unlike the subtree &&-chain case, this breakage is at the top-level, thus was caught by the normal --chain-lint mechanism, not the subshell linter. [1]: https://public-inbox.org/git/20180730190612.GB156463@aiede.svl.corp.google. com/ contrib/mw-to-git/t/t9360-mw-to-git-clone.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh b/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh index 22f069db48..cfbfe7ddf6 100755 --- a/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh +++ b/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh @@ -247,7 +247,7 @@ test_expect_success 'Test of resistance to modification of category on wiki for wiki_editpage Notconsidered "this page will not appear on local" false && wiki_editpage Othercategory "this page will not appear on local" false -c=Cattwo && wiki_editpage Tobeedited "this page have been modified" true -c=Catone && - wiki_delete_page Tobedeleted + wiki_delete_page Tobedeleted && git clone -c remote.origin.categories="Catone" \ mediawiki::'"$WIKI_URL"' mw_dir_14 && wiki_getallpage ref_page_14 Catone && -- 2.18.0.597.ga71716f1ad ``` ## Jonathan Nieder, 2018-07-30 21:04 Subject: Re: [PATCH] mw-to-git/t9360: fix broken &&-chain Message-ID: <20180730210438.GF156463@aiede.svl.corp.google.com> URL: https://gitlist.dev/e/20180730210438.GF156463%40aiede.svl.corp.google.com In-Reply-To: <20180730204646.32312-1-sunshine@sunshineco.com> ``` (+cc: some folks interested in git-remote-mediawiki) Hi, Eric Sunshine wrote: > Signed-off-by: Eric Sunshine > --- > Jonathan's discovery[1] of a broken &&-chain in a contrib/subtree test > prompted me to check other tests bundled in contrib/. This was the > only other problem found. Unlike the subtree &&-chain case, this > breakage is at the top-level, thus was caught by the normal > --chain-lint mechanism, not the subshell linter. > > [1]: https://public-inbox.org/git/20180730190612.GB156463@aiede.svl.corp.google. > com/ A small detail from there would be useful to have in the commit message: namely that this was detected using --chain-lint (and what command I can run to reproduce it myself). With or without such a tweak to the commit message, Reviewed-by: Jonathan Nieder Thanks. > contrib/mw-to-git/t/t9360-mw-to-git-clone.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh b/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh > index 22f069db48..cfbfe7ddf6 100755 > --- a/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh > +++ b/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh > @@ -247,7 +247,7 @@ test_expect_success 'Test of resistance to modification of category on wiki for > wiki_editpage Notconsidered "this page will not appear on local" false && > wiki_editpage Othercategory "this page will not appear on local" false -c=Cattwo && > wiki_editpage Tobeedited "this page have been modified" true -c=Catone && > - wiki_delete_page Tobedeleted > + wiki_delete_page Tobedeleted && > git clone -c remote.origin.categories="Catone" \ > mediawiki::'"$WIKI_URL"' mw_dir_14 && > wiki_getallpage ref_page_14 Catone && > -- > 2.18.0.597.ga71716f1ad > ``` ## Matthieu Moy, 2018-08-08 16:10 Subject: Re: [PATCH] mw-to-git/t9360: fix broken &&-chain Message-ID: <1760070169.15343864.1533744622227.JavaMail.zimbra@inria.fr> URL: https://gitlist.dev/e/1760070169.15343864.1533744622227.JavaMail.zimbra%40inria.fr In-Reply-To: <9a96cf8f5254446fa244e4107cef4f3c@BPMBX2013-01.univ-lyon1.fr> ``` "jrnieder" wrote: > (+cc: some folks interested in git-remote-mediawiki) Thanks. In case it still matters, an obvious Acked-by: Matthieu Moy -- Matthieu Moy ``` ## Antoine Beaupré, 2018-08-21 18:55 Subject: Re: [PATCH] mw-to-git/t9360: fix broken &&-chain Message-ID: <87zhxf5z38.fsf@curie.anarc.at> URL: https://gitlist.dev/e/87zhxf5z38.fsf%40curie.anarc.at In-Reply-To: <1760070169.15343864.1533744622227.JavaMail.zimbra@inria.fr> ``` On 2018-08-08 18:10:22, Matthieu Moy wrote: > "jrnieder" wrote: > >> (+cc: some folks interested in git-remote-mediawiki) > > Thanks. > > In case it still matters, an obvious Acked-by: Matthieu Moy Hi, I seem to have lost context of the original email, and can't find a copy on public-inbox.org... Is there a patch we should merge back into git-mediawiki already? Thanks! A. -- Your injured body has become the burden of your digital soul. - Yin Aiwen, 2013, The Massage is the Medium ``` ## Eric Sunshine, 2018-08-21 19:22 Subject: Re: [PATCH] mw-to-git/t9360: fix broken &&-chain Message-ID: URL: https://gitlist.dev/e/CAPig%2BcQVhacEuMmKbB2VMkrga900a97pENRZZbDJ2KUHx3n7gA%40mail.gmail.com In-Reply-To: <87zhxf5z38.fsf@curie.anarc.at> ``` On Tue, Aug 21, 2018 at 2:55 PM Antoine Beaupré wrote: > On 2018-08-08 18:10:22, Matthieu Moy wrote: > > "jrnieder" wrote: > >> (+cc: some folks interested in git-remote-mediawiki) > > > > In case it still matters, an obvious Acked-by: Matthieu Moy > > I seem to have lost context of the original email, and can't find a copy > on public-inbox.org... Is there a patch we should merge back into > git-mediawiki already? The patch is here[1]. [1]: https://public-inbox.org/git/20180730204646.32312-1-sunshine@sunshineco.com/ ``` ## Antoine Beaupré, 2018-08-21 19:29 Subject: Re: [PATCH] mw-to-git/t9360: fix broken &&-chain Message-ID: <87r2ir5xiy.fsf@curie.anarc.at> URL: https://gitlist.dev/e/87r2ir5xiy.fsf%40curie.anarc.at In-Reply-To: ``` On 2018-08-21 15:22:43, Eric Sunshine wrote: > On Tue, Aug 21, 2018 at 2:55 PM Antoine Beaupré wrote: >> On 2018-08-08 18:10:22, Matthieu Moy wrote: >> > "jrnieder" wrote: >> >> (+cc: some folks interested in git-remote-mediawiki) >> > >> > In case it still matters, an obvious Acked-by: Matthieu Moy >> >> I seem to have lost context of the original email, and can't find a copy >> on public-inbox.org... Is there a patch we should merge back into >> git-mediawiki already? > > The patch is here[1]. > > [1]: https://public-inbox.org/git/20180730204646.32312-1-sunshine@sunshineco.com/ Thanks, so Acked-by: Antoine Beaupré FWIW. :) A. -- The history of any one part of the earth, like the life of a soldier, consists of long periods of boredom and short periods of terror. - British geologist Derek V. Ager ```