# [PATCH] doc: fix want-capability separator 2 messages from 2018-07-28 to 2018-07-30. Participants: Masaya Suzuki, Stefan Beller. Thread: https://gitlist.dev/t/48968 ## Masaya Suzuki, 2018-07-28 21:16 Subject: [PATCH] doc: fix want-capability separator Message-ID: <20180728211630.29573-1-masayasuzuki@google.com> URL: https://gitlist.dev/e/20180728211630.29573-1-masayasuzuki%40google.com ``` Unlike ref advertisement, client capabilities and the first want are separated by SP, not NUL, in the implementation. Fix the documentation to align with the implementation. pack-protocol.txt is already fixed. Signed-off-by: Masaya Suzuki --- Documentation/technical/http-protocol.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/technical/http-protocol.txt b/Documentation/technical/http-protocol.txt index 64f49d0bb..9c5b6f0fa 100644 --- a/Documentation/technical/http-protocol.txt +++ b/Documentation/technical/http-protocol.txt @@ -338,11 +338,11 @@ server advertises capability `allow-tip-sha1-in-want` or request_end request_end = "0000" / "done" - want_list = PKT-LINE(want NUL cap_list LF) + want_list = PKT-LINE(want SP cap_list LF) *(want_pkt) want_pkt = PKT-LINE(want LF) want = "want" SP id - cap_list = *(SP capability) SP + cap_list = capability *(SP capability) have_list = *PKT-LINE("have" SP id LF) -- 2.18.0 ``` ## Stefan Beller, 2018-07-30 18:26 Subject: Re: [PATCH] doc: fix want-capability separator Message-ID: URL: https://gitlist.dev/e/CAGZ79kYOqP-8t1r_-NVLA025UP%2B_Zi5SXHWfc7HxRo9gemWDpQ%40mail.gmail.com In-Reply-To: <20180728211630.29573-1-masayasuzuki@google.com> ``` On Sat, Jul 28, 2018 at 2:16 PM Masaya Suzuki wrote: > Signed-off-by: Masaya Suzuki The email addresses mismatch? > Unlike ref advertisement, client capabilities and the first want are > separated by SP, not NUL, in the implementation. Fix the documentation > to align with the implementation. Makes sense! Thanks for the fix! > pack-protocol.txt is already fixed. which has capability-list = capability *(SP capability) since b31222cfb7f (Update packfile transfer protocol documentation, 2009-11-03), which is the first to mention the capability line, so I'd claim it was always correct? > > --- > Documentation/technical/http-protocol.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/technical/http-protocol.txt b/Documentation/technical/http-protocol.txt > index 64f49d0bb..9c5b6f0fa 100644 > --- a/Documentation/technical/http-protocol.txt > +++ b/Documentation/technical/http-protocol.txt > @@ -338,11 +338,11 @@ server advertises capability `allow-tip-sha1-in-want` or > request_end > request_end = "0000" / "done" > > - want_list = PKT-LINE(want NUL cap_list LF) > + want_list = PKT-LINE(want SP cap_list LF) > *(want_pkt) > want_pkt = PKT-LINE(want LF) > want = "want" SP id > - cap_list = *(SP capability) SP > + cap_list = capability *(SP capability) > > have_list = *PKT-LINE("have" SP id LF) Just after these context lines we have TODO: Document this further. which is a good hint that the existing documentation can benefit from patches like these. Thanks, Stefan ```