# [PATCH] t7406-submodule-update: fix broken &&-chains

2 messages from 2018-06-16 to 2018-06-18. Participants: SZEDER Gábor, Stefan Beller.
Thread: https://gitlist.dev/t/48723

## SZEDER Gábor, 2018-06-16 20:33

Subject: [PATCH] t7406-submodule-update: fix broken &&-chains
Message-ID: <20180616203319.9558-1-szeder.dev@gmail.com>
URL: https://gitlist.dev/e/20180616203319.9558-1-szeder.dev%40gmail.com

```
Three tests in 't7406-submodule-update' contain broken &&-chains, but
since they are all in subshells, chain-lint couldn't notice them.

Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
---
 t/t7406-submodule-update.sh | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/t/t7406-submodule-update.sh b/t/t7406-submodule-update.sh
index 6f083c4d68..9e0d31700e 100755
--- a/t/t7406-submodule-update.sh
+++ b/t/t7406-submodule-update.sh
@@ -65,7 +65,7 @@ test_expect_success 'setup a submodule tree' '
 	 git commit -m "none"
 	) &&
 	git clone . recursivesuper &&
-	( cd recursivesuper
+	( cd recursivesuper &&
 	 git submodule add ../super super
 	)
 '
@@ -245,13 +245,13 @@ test_expect_success 'submodule update --remote should fetch upstream changes wit
 	(
 		cd super &&
 		git submodule update --remote --force submodule &&
-		git -C submodule log -1 --oneline >actual
-		git -C ../submodule log -1 --oneline master >expect
+		git -C submodule log -1 --oneline >actual &&
+		git -C ../submodule log -1 --oneline master >expect &&
 		test_cmp expect actual &&
 		git checkout -b test-branch &&
 		git submodule update --remote --force submodule &&
-		git -C submodule log -1 --oneline >actual
-		git -C ../submodule log -1 --oneline test-branch >expect
+		git -C submodule log -1 --oneline >actual &&
+		git -C ../submodule log -1 --oneline test-branch >expect &&
 		test_cmp expect actual &&
 		git checkout master &&
 		git branch -d test-branch &&
@@ -891,7 +891,7 @@ test_expect_success 'submodule update properly revives a moved submodule' '
 	 rm -rf submodule2 &&
 	 mkdir -p "moved/sub module" &&
 	 git update-index --add --cacheinfo 160000 $H "moved/sub module" &&
-	 git config -f .gitmodules submodule.submodule2.path "moved/sub module"
+	 git config -f .gitmodules submodule.submodule2.path "moved/sub module" &&
 	 git commit -am "post move" &&
 	 git submodule update &&
 	 git status | sed "s/$H2/XXX/" >actual &&
-- 
2.18.0.rc0.207.ga6211da864


```

## Stefan Beller, 2018-06-18 17:48

Subject: Re: [PATCH] t7406-submodule-update: fix broken &&-chains
Message-ID: <CAGZ79kaijLGr4LBWyS5z6QwNzmPkrNVGcatpqW0nnBWwOUe4Mw@mail.gmail.com>
URL: https://gitlist.dev/e/CAGZ79kaijLGr4LBWyS5z6QwNzmPkrNVGcatpqW0nnBWwOUe4Mw%40mail.gmail.com
In-Reply-To: <20180616203319.9558-1-szeder.dev@gmail.com>

```
On Sat, Jun 16, 2018 at 1:33 PM SZEDER Gábor <szeder.dev@gmail.com> wrote:
>
> Three tests in 't7406-submodule-update' contain broken &&-chains, but
> since they are all in subshells, chain-lint couldn't notice them.
>
> Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>

This looks good to me;

Thanks for spotting and fixing it,
Stefan

```