threads / patch / 48633

patcht/perf/run: Use proper "--get-regexp", not "get-regex"

Subject: [PATCH] t/perf/run: Use proper "--get-regexp", not "get-regex"

## tl;dr

One message between Jun 3, 2018 and Jun 3, 2018. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Robert P. J. Day· Jun 3, 2018, 10:11 UTC · lore

Even though "--get-regex" appears to work with "git config", the standard is to spell out the action in full.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
---

this is the only occurrence i saw of this in the entire code base, so it seemed worth tweaking just for consistency.

Show changes to t/perf/run +1 −1
diff --git a/t/perf/run b/t/perf/run
index 9aaa733c7..fb5753ea2 100755
--- a/t/perf/run
+++ b/t/perf/run
@@ -110,7 +110,7 @@ run_dirs () {
 get_subsections () {
 	section="$1"
 	test -z "$GIT_PERF_CONFIG_FILE" && return
-	git config -f "$GIT_PERF_CONFIG_FILE" --name-only --get-regex "$section\..*\.[^.]+" |
+	git config -f "$GIT_PERF_CONFIG_FILE" --name-only --get-regexp "$section\..*\.[^.]+" |
 	sed -e "s/$section\.\(.*\)\..*/\1/" | sort | uniq
 }
-- 
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                  http://crashcourse.ca/dokuwiki

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

← back to recent threads