# [PATCH] commit-graph: fix a sparse 'integer as NULL pointer' warning 2 messages from 2018-05-29 to 2018-05-30. Participants: Ramsay Jones, Derrick Stolee. Thread: https://gitlist.dev/t/48593 ## Ramsay Jones, 2018-05-29 20:01 Subject: [PATCH] commit-graph: fix a sparse 'integer as NULL pointer' warning Message-ID: URL: https://gitlist.dev/e/b22d20c2-f084-1727-cb98-06707e874ef1%40ramsayjones.plus.com ``` Signed-off-by: Ramsay Jones --- Hi Derrick, If you need to re-roll your 'ds/commit-graph-fsck' branch (pu@a84e06bc0f), could you please squash this into the relevant patch (commit 80453b4529, "commit-graph: add 'verify' subcommand", 2018-05-24). [No, No, that was the one in graph_read(). :-D ] Thanks! ATB, Ramsay Jones builtin/commit-graph.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/commit-graph.c b/builtin/commit-graph.c index 20ce6437a..6abfde5e6 100644 --- a/builtin/commit-graph.c +++ b/builtin/commit-graph.c @@ -39,7 +39,7 @@ static struct opts_commit_graph { static int graph_verify(int argc, const char **argv) { - struct commit_graph *graph = 0; + struct commit_graph *graph = NULL; char *graph_name; static struct option builtin_commit_graph_verify_options[] = { -- 2.17.0 ``` ## Derrick Stolee, 2018-05-30 00:57 Subject: Re: [PATCH] commit-graph: fix a sparse 'integer as NULL pointer' warning Message-ID: URL: https://gitlist.dev/e/ba3b8e06-b5e1-99a1-0fe4-ff97d6da8f15%40gmail.com In-Reply-To: ``` n 5/29/2018 4:01 PM, Ramsay Jones wrote: > Signed-off-by: Ramsay Jones > --- > > Hi Derrick, > > If you need to re-roll your 'ds/commit-graph-fsck' branch (pu@a84e06bc0f), > could you please squash this into the relevant patch (commit 80453b4529, > "commit-graph: add 'verify' subcommand", 2018-05-24). > > [No, No, that was the one in graph_read(). :-D ] Thanks for helping rid me of my bad habits! I'll get this one in v4. > > Thanks! > > ATB, > Ramsay Jones > > builtin/commit-graph.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/builtin/commit-graph.c b/builtin/commit-graph.c > index 20ce6437a..6abfde5e6 100644 > --- a/builtin/commit-graph.c > +++ b/builtin/commit-graph.c > @@ -39,7 +39,7 @@ static struct opts_commit_graph { > > static int graph_verify(int argc, const char **argv) > { > - struct commit_graph *graph = 0; > + struct commit_graph *graph = NULL; > char *graph_name; > > static struct option builtin_commit_graph_verify_options[] = { ```