# [PATCH] t990X: use '.git/objects' as 'deep inside .git' path 3 messages from 2018-05-26 to 2018-05-29. Participants: Christian Couder, Michael Haggerty, Derrick Stolee. Thread: https://gitlist.dev/t/48576 ## Christian Couder, 2018-05-26 06:47 Subject: [PATCH] t990X: use '.git/objects' as 'deep inside .git' path Message-ID: <20180526064745.20199-1-chriscool@tuxfamily.org> URL: https://gitlist.dev/e/20180526064745.20199-1-chriscool%40tuxfamily.org ``` Tests t9902-completion.sh and t9903-bash-prompt.sh each have tests that check what happens when we are "in the '.git' directory" and when we are "deep inside the '.git' directory". To test the case when we are "deep inside the '.git' directory" the test scripts used to perform a `cd .git/refs/heads`. As there are plans to implement other ref storage systems, let's use '.git/objects' instead of '.git/refs/heads' as the "deep inside the '.git' directory" path. This makes it clear to readers that these tests do not depend on which ref backend is used. The internals of the loose refs backend are still tested in t1400-update-ref.sh. Helped-by: SZEDER Gábor Signed-off-by: David Turner Signed-off-by: Christian Couder --- t/t9902-completion.sh | 2 +- t/t9903-bash-prompt.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh index 36deb0b123..a28640ce1a 100755 --- a/t/t9902-completion.sh +++ b/t/t9902-completion.sh @@ -181,7 +181,7 @@ test_expect_success '__git_find_repo_path - cwd is a .git directory' ' test_expect_success '__git_find_repo_path - parent is a .git directory' ' echo "$ROOT/.git" >expected && ( - cd .git/refs/heads && + cd .git/objects && __git_find_repo_path && echo "$__git_repo_path" >"$actual" ) && diff --git a/t/t9903-bash-prompt.sh b/t/t9903-bash-prompt.sh index 8f5c811dd7..c3b89ae783 100755 --- a/t/t9903-bash-prompt.sh +++ b/t/t9903-bash-prompt.sh @@ -148,7 +148,7 @@ test_expect_success 'prompt - inside .git directory' ' test_expect_success 'prompt - deep inside .git directory' ' printf " (GIT_DIR!)" >expected && ( - cd .git/refs/heads && + cd .git/objects && __git_ps1 >"$actual" ) && test_cmp expected "$actual" -- 2.17.0.1181.g093e983b05.dirty ``` ## Michael Haggerty, 2018-05-27 04:49 Subject: Re: [PATCH] t990X: use '.git/objects' as 'deep inside .git' path Message-ID: URL: https://gitlist.dev/e/CAMy9T_H7OVJoDQGFNnM-GrCE9jhSqNDALFL1TM45TMcwPx5nnQ%40mail.gmail.com In-Reply-To: <20180526064745.20199-1-chriscool@tuxfamily.org> ``` On Sat, May 26, 2018 at 8:47 AM, Christian Couder wrote: > Tests t9902-completion.sh and t9903-bash-prompt.sh each have tests > that check what happens when we are "in the '.git' directory" and > when we are "deep inside the '.git' directory". > > To test the case when we are "deep inside the '.git' directory" the > test scripts used to perform a `cd .git/refs/heads`. > > As there are plans to implement other ref storage systems, let's > use '.git/objects' instead of '.git/refs/heads' as the "deep inside > the '.git' directory" path. Seems reasonable to me. +1. Michael ``` ## Derrick Stolee, 2018-05-29 11:58 Subject: Re: [PATCH] t990X: use '.git/objects' as 'deep inside .git' path Message-ID: <50c85752-7000-880e-ebfd-44b8e7f71028@gmail.com> URL: https://gitlist.dev/e/50c85752-7000-880e-ebfd-44b8e7f71028%40gmail.com In-Reply-To: ``` On 5/27/2018 12:49 AM, Michael Haggerty wrote: > On Sat, May 26, 2018 at 8:47 AM, Christian Couder > wrote: >> Tests t9902-completion.sh and t9903-bash-prompt.sh each have tests >> that check what happens when we are "in the '.git' directory" and >> when we are "deep inside the '.git' directory". >> >> To test the case when we are "deep inside the '.git' directory" the >> test scripts used to perform a `cd .git/refs/heads`. >> >> As there are plans to implement other ref storage systems, let's >> use '.git/objects' instead of '.git/refs/heads' as the "deep inside >> the '.git' directory" path. > Seems reasonable to me. +1. > > Michael Looks good to me, too. Thanks, -Stolee ```