threads / patch / 48407

v2perf/bisect_run_script: disable codespeed

Subject: [PATCH v2] perf/bisect_run_script: disable codespeed

## tl;dr

One message between May 4, 2018 and May 4, 2018. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Christian Couder· May 4, 2018, 12:36 UTC · lore

When bisecting a performance regression using a config file, `./bisect_regression --config my_perf.conf` for example, the config file can contain Codespeed configuration which would instruct the 'aggregate.perl' script called by the 'run' script to output results in the Codespeed format and maybe to try to send this output to a Codespeed server.

This is unfortunate because the 'bisect_run_script' relies on the regular output from 'aggregate.perl' to mesure performance, so let's disable Codespeed output and sending results to a Codespeed server.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
Previous version was:
https://public-inbox.org/git/20180427135135.22931-1-chriscool@tuxfamily.org/

The only change compared to this previous version is a typo fix in the commit message:

s/This in unfortunate/This is unfortunate/
 t/perf/bisect_run_script | 6 ++++++
 1 file changed, 6 insertions(+)
Show changes to t/perf/bisect_run_script +6 −0
diff --git a/t/perf/bisect_run_script b/t/perf/bisect_run_script
index 038255df4b..3ebaf15521 100755
--- a/t/perf/bisect_run_script
+++ b/t/perf/bisect_run_script
@@ -24,6 +24,12 @@ result_file="$info_dir/perf_${script_number}_${bisect_head}_results.txt"
 GIT_PERF_DIRS_OR_REVS="$bisect_head"
 export GIT_PERF_DIRS_OR_REVS
 
+# Don't use codespeed
+GIT_PERF_CODESPEED_OUTPUT=
+GIT_PERF_SEND_TO_CODESPEED=
+export GIT_PERF_CODESPEED_OUTPUT
+export GIT_PERF_SEND_TO_CODESPEED
+
 ./run "$script" >"$result_file" 2>&1 || die "Failed to run perf test '$script'"
 
 rtime=$(sed -n "s/^$script_number\.$test_number:.*\([0-9]\+\.[0-9]\+\)(.*).*\$/\1/p" "$result_file")
-- 
2.17.0.400.gd2f70daabc

← back to recent threads