threads / patch / 48338

patch, 6 partsTeach '--column-number' to 'git-grep(1)'

Subject: [PATCH 0/6] Teach '--column-number' to 'git-grep(1)'

## tl;dr

One message between Apr 21, 2018 and Apr 21, 2018. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Taylor Blau· Apr 21, 2018, 03:45 UTC · lore
Hi,

Attached is a series to add --column-number to 'git-grep(1)', and support jumping to the correct column when using Peff's 'git-jump'.

I have chosen -m as the short form of --column-number, because -c was taken, and -m is close to -n (the short form of --line-number).

The description in each patch is extensive, and can serve as a reference during review. Thank you in advance for your time, and--as always--I look forward to your feedback :-).

Thanks, Taylor

Taylor Blau (6):
  grep.c: take regmatch_t as argument in match_line()
  grep.c: take column number as argument to show_line()
  grep.[ch]: teach columnnum, color_columnno to grep_opt
  grep.c: display column number of first match
  builtin/grep.c: show column numbers via --column-number
  contrib/git-jump/git-jump: use column number when grep-ing
 Documentation/config.txt   |  5 +++++
 Documentation/git-grep.txt |  9 ++++++++-
 builtin/grep.c             |  1 +
 contrib/git-jump/git-jump  |  2 +-
 grep.c                     | 33 ++++++++++++++++++++++++---------
 grep.h                     |  2 ++
 t/t7810-grep.sh            | 22 ++++++++++++++++++++++
 7 files changed, 63 insertions(+), 11 deletions(-)

-- 2.17.0

← back to recent threads