threads / discuss / 48234

Git send-email not sending email patches as subsequent replies

Subject: Git send-email not sending email patches as subsequent replies

## tl;dr

3 messages between Apr 6, 2018 and Apr 8, 2018.

replies: 2people: 2as markdown or json

David Davis· Apr 6, 2018, 19:28 UTC · lore
Hello, I have the following git send-email command:

git send-email -5 --quiet --thread --no-chain-reply-to --compose --subject='Recent Base Prototype Changes Summary' --to=davisdavid@google.com --from=davisdavid@google.com

It's sending emails but as 5 individual emails and not as subsequent replies as suggested on https://git-scm.com/docs/git-send-email below:

So for example when --thread and --no-chain-reply-to are specified, the second and subsequent patches will be replies to the first one like in the illustration below where [PATCH v2 0/3] is in reply to [PATCH 0/2]:

[PATCH 0/2] Here is what I did...
  [PATCH 1/2] Clean up and tests
  [PATCH 2/2] Implementation
  [PATCH v2 0/3] Here is a reroll
    [PATCH v2 1/3] Clean up
    [PATCH v2 2/3] New tests
    [PATCH v2 3/3] Implementation
What am I missing?

Thanks, David

Eric Wong· Apr 7, 2018, 23:08 UTC · re: David Davis · lore

Re: Git send-email not sending email patches as subsequent replies

David Davis <davidjamesdavis.djd@gmail.com> wrote:
Show 8 quoted lines
> Hello, I have the following git send-email command:
> 
> git send-email -5 --quiet --thread --no-chain-reply-to --compose
> --subject='Recent Base Prototype Changes Summary'
> --to=davisdavid@google.com --from=davisdavid@google.com
> 
> It's sending emails but as 5 individual emails and not as subsequent
> replies as suggested on https://git-scm.com/docs/git-send-email below:
So, I expect the above command should give you six emails:
  [PATCH 0/5] Recent Base Prototype Changes Summary
    [PATCH 1/5]
    [PATCH 2/5]
    [PATCH 3/5]
    [PATCH 4/5]
    [PATCH 5/5]
Is that not what you're seeing?

You're quoting the manpage for --in-reply-to option below, but you're not using that option.

Show 14 quoted lines
> So for example when --thread and --no-chain-reply-to are specified,
> the second and subsequent patches will be replies to the first one
> like in the illustration below where [PATCH v2 0/3] is in reply to
> [PATCH 0/2]:
> 
> [PATCH 0/2] Here is what I did...
>   [PATCH 1/2] Clean up and tests
>   [PATCH 2/2] Implementation
>   [PATCH v2 0/3] Here is a reroll
>     [PATCH v2 1/3] Clean up
>     [PATCH v2 2/3] New tests
>     [PATCH v2 3/3] Implementation
> 
> What am I missing?

I'm not sure... I suspect you're either not using --in-reply-to= or misreading the manpage, somehow.

Eric Wong· Apr 8, 2018, 02:47 UTC · lore

Re: Git send-email not sending email patches as subsequent replies

David Davis <davidjamesdavis.djd@gmail.com> wrote:
> I'm seeing 6 individual emails, how do I just see one email followed by 5
> email replies to the one? I don't want six individual emails.
The five email replies you want are still individual emails.
Emails are ALWAYS "individual", and reply emails simply have a
References: and/or In-Reply-To: header in them.

Whether your mail client shows them as individual mails is another story. I also suspect whatever mail client you're using isn't rendering thread hierarchies correctly.

Most good mail clients use the same algorithm to display message threads since the days of Netscape:

	https://www.jwz.org/doc/threading.html
I've also modified that algorithm to be recursion-free for public-inbox:
	https://rt.cpan.org/Public/Bug/Display.html?id=116727

Btw, please disable HTML mail in your mail client or it won't show up on the list (and other people won't be able to help). I may not be around much for a bit.

← back to recent threads