# Running some tests with -x fails 2 messages from 2018-03-14 to 2018-03-14. Participants: Christian Couder, Jeff King. Thread: https://gitlist.dev/t/48040 ## Christian Couder, 2018-03-14 14:30 Subject: Running some tests with -x fails Message-ID: URL: https://gitlist.dev/e/CAP8UFD29eFPfiW2PjOr4evjB2X%3DyDWULOgUx2NRM83Mt0FDXUw%40mail.gmail.com ``` I don't know if this is well known already, but when when I run some tests using -x on master they consistently fail (while they consistently pass without -x). For example: ./t5500-fetch-pack.sh -x gives: # failed 3 among 353 test(s) ./t0008-ignores.sh -x gives: # failed 208 among 394 test(s) Are we interested in trying to fix those failures or are we ok with them? ``` ## Jeff King, 2018-03-14 14:50 Subject: Re: Running some tests with -x fails Message-ID: <20180314145050.GA15531@sigill.intra.peff.net> URL: https://gitlist.dev/e/20180314145050.GA15531%40sigill.intra.peff.net In-Reply-To: ``` On Wed, Mar 14, 2018 at 03:30:30PM +0100, Christian Couder wrote: > I don't know if this is well known already, but when when I run some > tests using -x on master they consistently fail (while they > consistently pass without -x). > > For example: > > ./t5500-fetch-pack.sh -x > > gives: # failed 3 among 353 test(s) > > ./t0008-ignores.sh -x > > gives: # failed 208 among 394 test(s) > > Are we interested in trying to fix those failures or are we ok with them? This is known; the issue is tests that run shell functions or subshells and capture their stderr (which then get polluted by "-x" output). You can either: - run the tests with bash, which uses BASH_XTRACEFD to send output directly to the terminal (see TEST_SHELL_PATH in recent versions) - try 'next'; Gábor has done some work recently to clean up tests so that this works even with non-bash shells. See the sg/test-x and sg/cvs-tests-with-x topics. -Peff ```