threads / patch / 47935

patchdocs/pretty-formats: fix typo '% <(<N>)' -> '%<|(<N>)'

Subject: [PATCH] docs/pretty-formats: fix typo '% <(<N>)' -> '%<|(<N>)'

## tl;dr

3 messages between Feb 27, 2018 and Feb 28, 2018. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Mårten Kongstad· Feb 27, 2018, 20:17 UTC · lore

Remove erroneous space between % and < in '% <(<N>)'.

Signed-off-by: Mårten Kongstad <marten.kongstad@gmail.com>
---
 Documentation/pretty-formats.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to Documentation/pretty-formats.txt +1 −1

diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt
index e664c08..6109ef0 100644
--- a/Documentation/pretty-formats.txt
+++ b/Documentation/pretty-formats.txt
@@ -202,7 +202,7 @@ endif::git-rev-list[]
 - '%>>(<N>)', '%>>|(<N>)': similar to '%>(<N>)', '%>|(<N>)'
   respectively, except that if the next placeholder takes more spaces
   than given and there are spaces on its left, use those spaces
-- '%><(<N>)', '%><|(<N>)': similar to '% <(<N>)', '%<|(<N>)'
+- '%><(<N>)', '%><|(<N>)': similar to '%<(<N>)', '%<|(<N>)'
   respectively, but padding both sides (i.e. the text is centered)
 - %(trailers[:options]): display the trailers of the body as interpreted
   by linkgit:git-interpret-trailers[1]. The `trailers` string may be

-- 
1.9.1

Jonathan Nieder· Feb 27, 2018, 20:24 UTC · re: Mårten Kongstad · lore

Re: [PATCH] docs/pretty-formats: fix typo '% <(<N>)' -> '%<|(<N>)'

Mårten Kongstad wrote:

Show 6 quoted lines

> Remove erroneous space between % and < in '% <(<N>)'.
>
> Signed-off-by: Mårten Kongstad <marten.kongstad@gmail.com>
> ---
>  Documentation/pretty-formats.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Looks correct to me. The space was introduced in v1.8.3-rc0~22^2 (pretty: support %>> that steals trailing spaces, 2013-04-19) and appears to be a plain typo. Thanks for fixing it.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.

Show 11 quoted lines

> --- a/Documentation/pretty-formats.txt
> +++ b/Documentation/pretty-formats.txt
> @@ -202,7 +202,7 @@ endif::git-rev-list[]
>  - '%>>(<N>)', '%>>|(<N>)': similar to '%>(<N>)', '%>|(<N>)'
>    respectively, except that if the next placeholder takes more spaces
>    than given and there are spaces on its left, use those spaces
> -- '%><(<N>)', '%><|(<N>)': similar to '% <(<N>)', '%<|(<N>)'
> +- '%><(<N>)', '%><|(<N>)': similar to '%<(<N>)', '%<|(<N>)'
>    respectively, but padding both sides (i.e. the text is centered)
>  - %(trailers[:options]): display the trailers of the body as interpreted
>    by linkgit:git-interpret-trailers[1]. The `trailers` string may be

Duy Nguyen· Feb 28, 2018, 09:39 UTC · re: Jonathan Nieder · lore

Re: [PATCH] docs/pretty-formats: fix typo '% <(<N>)' -> '%<|(<N>)'

On Wed, Feb 28, 2018 at 3:24 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 12 quoted lines

> Mårten Kongstad wrote:
>
>> Remove erroneous space between % and < in '% <(<N>)'.
>>
>> Signed-off-by: Mårten Kongstad <marten.kongstad@gmail.com>
>> ---
>>  Documentation/pretty-formats.txt | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Looks correct to me.  The space was introduced in v1.8.3-rc0~22^2
> (pretty: support %>> that steals trailing spaces, 2013-04-19) and
> appears to be a plain typo.  Thanks for fixing it.

Yeah definitely a good change.

-- 
Duy