[PATCH] test-lib.sh: unset XDG_CACHE_HOME

Genki Sky· Feb 16, 2018, 02:46 UTC · lore

git respects XDG_CACHE_HOME for the credential cache. So, we should unset XDG_CACHE_HOME for the test environment, lest a user's custom one cause failure in the test.

For example, t/t0301-credential-cache.sh expects a default directory to be used if it hasn't explicitly set XDG_CACHE_HOME.

Signed-off-by: Genki Sky <sky@genki.is>
---

Notes:

  This is the XDG_CACHE_HOME version of 5adf84ebb ("test-lib.sh: unset
  XDG_CONFIG_HOME", 2012-07-24).

 t/test-lib.sh | 1 +
 1 file changed, 1 insertion(+)

Show changes to t/test-lib.sh +1 −1

diff --git a/t/test-lib.sh b/t/test-lib.sh
index 9af19055b..001ef6b64 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -116,6 +116,7 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $("$PERL_PATH" -e '
 	my @vars = grep(/^GIT_/ && !/^GIT_($ok)/o, @env);
 	print join("\n", @vars);
 ')
+unset XDG_CACHE_HOME
 unset XDG_CONFIG_HOME
 unset GITPERLLIB
 GIT_AUTHOR_EMAIL=author@example.com
--
2.16.1.195.g373da842b

Jeff King· Feb 16, 2018, 18:35 UTC · re: Genki Sky · lore

Re: [PATCH] test-lib.sh: unset XDG_CACHE_HOME

On Thu, Feb 15, 2018 at 09:46:04PM -0500, Genki Sky wrote:

Show 6 quoted lines

> git respects XDG_CACHE_HOME for the credential cache. So, we should
> unset XDG_CACHE_HOME for the test environment, lest a user's custom one
> cause failure in the test.
> 
> For example, t/t0301-credential-cache.sh expects a default directory
> to be used if it hasn't explicitly set XDG_CACHE_HOME.

Yep, this makes perfect sense. I can't believe it took almost a year for somebody to trigger this. I guess most people don't set XDG_CACHE_HOME.

Thanks.

-Peff

patchtest-lib.sh: unset XDG_CACHE_HOME