# [PATCH] Beautifulise git-show output 3 messages from 2006-07-04 to 2006-07-04. Participants: beber.mailing@gmail.com, Junio C Hamano, Bertrand Jacquin. Thread: https://gitlist.dev/t/4768 ## beber.mailing@gmail.com, 2006-07-04 22:34 Subject: [PATCH] Beautifulise git-show output Message-ID: <11520525682686-git-send-email-beber.mailing@gmail.com> URL: https://gitlist.dev/e/11520525682686-git-send-email-beber.mailing%40gmail.com ``` From: Bertrand Jacquin (Beber) diff --git a/log-tree.c b/log-tree.c index ebb49f2..55f77ad 100644 --- a/log-tree.c +++ b/log-tree.c @@ -164,7 +164,7 @@ int log_tree_diff_flush(struct rev_info } if (opt->loginfo && !opt->no_commit_id) - show_log(opt, opt->loginfo, opt->diffopt.with_stat ? "---\n" : "\n"); + show_log(opt, opt->loginfo, opt->diffopt.with_stat ? "\n---\n" : "\n"); diff_flush(&opt->diffopt); return 1; } -- 1.4.1 ``` ## Junio C Hamano, 2006-07-04 22:51 Subject: Re: [PATCH] Beautifulise git-show output Message-ID: <7vejx1f0fz.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vejx1f0fz.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <11520525682686-git-send-email-beber.mailing@gmail.com> ``` Why? A patch like this needs to be justified with a bit more explanation; the word "beautiful" is subjective. (current) Change this and that file Signed-off-by: A U Thor --- this-file | 20 +++++++---- that-file | 4 ++++ 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/this-file b/this-file ... (yours -- and I think 1.3.0 did it like this) Change this and that file Signed-off-by: A U Thor --- this-file | 20 +++++++---- that-file | 4 ++++ 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/this-file b/this-file ... It _might_ be easier to read if it were like this, though: Change this and that file Signed-off-by: A U Thor --- this-file | 20 +++++++---- that-file | 4 ++++ 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/this-file b/this-file ... However, the screen real estate, especially in the vertical direction, is a scarce resource; I do not think the three-dash is a too weak visual separator that needs to be helped by an extra newline. ``` ## Bertrand Jacquin, 2006-07-04 22:59 Subject: Re: [PATCH] Beautifulise git-show output Message-ID: <4fb292fa0607041559t5dad90e3h5e764348a8b4c562@mail.gmail.com> URL: https://gitlist.dev/e/4fb292fa0607041559t5dad90e3h5e764348a8b4c562%40mail.gmail.com In-Reply-To: <7vejx1f0fz.fsf@assigned-by-dhcp.cox.net> ``` On 7/5/06, Junio C Hamano wrote: > Why? > > A patch like this needs to be justified with a bit more > explanation; the word "beautiful" is subjective. Arg, git-send-email seems to made a bad job after git-format-patch, sorry. So explanation don't go here. So here it is : Git-show actually show (for example) : Makefile: Create Makefile for Beamer theme rules are : install & uninstall (be careful on this one) Also, I hacked presentation oral's Makefile to check them presence or not --- docs/presentation_oral/Makefile | 5 +- docs/presentation_oral/themes/Makefile | 91 ++++++++++++++++++++++++++++++++ 2 files changed, 95 insertions(+), 1 deletions(-) create mode 100644 docs/presentation_oral/themes/Makefile I would like to have a newline after commit mesage too as there is one before diff-stat. -- # Beber : beber@gna.org # IM : beber@jabber.fr # http://guybrush.ath.cx, irc://irc.freenode.net/#{e.fr,gentoofr} ```