# [PATCH] rev-list: free commit_list in ... handler

2 messages from 2006-07-04 to 2006-07-04. Participants: Rene Scharfe, Junio C Hamano.
Thread: https://gitlist.dev/t/4766

## Rene Scharfe, 2006-07-04 19:22

Subject: [PATCH] rev-list: free commit_list in ... handler
Message-ID: <20060704192220.GA9500@lsrfire.ath.cx>
URL: https://gitlist.dev/e/20060704192220.GA9500%40lsrfire.ath.cx

```
Johannes noticed the missing call to free_commit_list() in the
patch from Santi to add ... support to rev-parse.  Turns out I
forgot it too in rev-list.  This patch is against the next branch
(3b1d06a).

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>

diff --git a/revision.c b/revision.c
index 66390c9..a7750e6 100644
--- a/revision.c
+++ b/revision.c
@@ -817,6 +817,7 @@ int setup_revisions(int argc, const char
 					exclude = get_merge_bases(a, b, 1);
 					add_pending_commit_list(revs, exclude,
 					                        flags_exclude);
+					free_commit_list(exclude);
 					a->object.flags |= flags;
 				} else
 					a->object.flags |= flags_exclude;

```

## Junio C Hamano, 2006-07-04 21:37

Subject: Re: [PATCH] rev-list: free commit_list in ... handler
Message-ID: <7v4pxxgigk.fsf@assigned-by-dhcp.cox.net>
URL: https://gitlist.dev/e/7v4pxxgigk.fsf%40assigned-by-dhcp.cox.net
In-Reply-To: <20060704192220.GA9500@lsrfire.ath.cx>

```
Thanks.

```