# [PATCH] Removed unnecessary void* from hashmap.h that caused compile warnings 5 messages from 2018-01-14 to 2018-01-16. Participants: randall.s.becker@rogers.com, Thomas Gummerer, Randall S. Becker, Junio C Hamano. Thread: https://gitlist.dev/t/47610 ## randall.s.becker@rogers.com, 2018-01-14 18:07 Subject: [PATCH] Removed unnecessary void* from hashmap.h that caused compile warnings Message-ID: <20180114180748.14584-1-randall.s.becker@rogers.com> URL: https://gitlist.dev/e/20180114180748.14584-1-randall.s.becker%40rogers.com ``` From: "Randall S. Becker" * hashmap.h: Revised the while loop in the hashmap_enable_item_counting to remove unneeded void* item. Signed-off-by: Randall S. Becker --- hashmap.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hashmap.h b/hashmap.h index 7ce79f3..d375d9c 100644 --- a/hashmap.h +++ b/hashmap.h @@ -400,7 +400,6 @@ static inline void hashmap_disable_item_counting(struct hashmap *map) */ static inline void hashmap_enable_item_counting(struct hashmap *map) { - void *item; unsigned int n = 0; struct hashmap_iter iter; @@ -408,7 +407,7 @@ static inline void hashmap_enable_item_counting(struct hashmap *map) return; hashmap_iter_init(map, &iter); - while ((item = hashmap_iter_next(&iter))) + while (hashmap_iter_next(&iter)) n++; map->do_count_items = 1; -- 2.8.5.23.g6fa7ec3 ``` ## Thomas Gummerer, 2018-01-15 20:43 Subject: Re: [PATCH] Removed unnecessary void* from hashmap.h that caused compile warnings Message-ID: <20180115204301.GL2641@hank> URL: https://gitlist.dev/e/20180115204301.GL2641%40hank In-Reply-To: <20180114180748.14584-1-randall.s.becker@rogers.com> ``` Thanks for your patch! A few nitpicks below: > Subject: [PATCH] Removed unnecessary void* from hashmap.h that caused compile warnings From Documentation/SubmittingPatches: Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behavior. I liked the subject Philip suggested in the other thread: "hashmap.h: remove unnecessary void*", or maybe "hashmap.h: remove unnecessary variable". On 01/14, randall.s.becker@rogers.com wrote: > From: "Randall S. Becker" > > * hashmap.h: Revised the while loop in the hashmap_enable_item_counting > to remove unneeded void* item. As above, this should be described in an imperative mood, and describe why this is a good change and should be merged. Maybe something along the lines of the below? In 'hashmap_enable_item_counting()', item is assigned but never used. This causes a warning on HP NonStop. As the variable is never used, fix this by just removing it. > Signed-off-by: Randall S. Becker > --- > hashmap.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/hashmap.h b/hashmap.h > index 7ce79f3..d375d9c 100644 > --- a/hashmap.h > +++ b/hashmap.h > @@ -400,7 +400,6 @@ static inline void hashmap_disable_item_counting(struct hashmap *map) > */ > static inline void hashmap_enable_item_counting(struct hashmap *map) > { > - void *item; > unsigned int n = 0; > struct hashmap_iter iter; > > @@ -408,7 +407,7 @@ static inline void hashmap_enable_item_counting(struct hashmap *map) > return; > > hashmap_iter_init(map, &iter); > - while ((item = hashmap_iter_next(&iter))) > + while (hashmap_iter_next(&iter)) > n++; > > map->do_count_items = 1; > -- > 2.8.5.23.g6fa7ec3 > ``` ## Randall S. Becker, 2018-01-15 20:49 Subject: RE: [PATCH] Removed unnecessary void* from hashmap.h that caused compile warnings Message-ID: <007801d38e42$6b6df3b0$4249db10$@nexbridge.com> URL: https://gitlist.dev/e/007801d38e42%246b6df3b0%244249db10%24%40nexbridge.com In-Reply-To: <20180115204301.GL2641@hank> ``` On January 15, 2018 3:43 PM, Thomas Gummerer wrote: > Thanks for your patch! A few nitpicks below: > > > Subject: [PATCH] Removed unnecessary void* from hashmap.h that caused > > compile warnings > > From Documentation/SubmittingPatches: > > Describe your changes in imperative mood, e.g. "make xyzzy do frotz" > instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy > to do frotz", as if you are giving orders to the codebase to change > its behavior. > > I liked the subject Philip suggested in the other thread: "hashmap.h: > remove unnecessary void*", or maybe "hashmap.h: remove unnecessary > variable". > > On 01/14, randall.s.becker@rogers.com wrote: > > From: "Randall S. Becker" > > > > * hashmap.h: Revised the while loop in the > hashmap_enable_item_counting > > to remove unneeded void* item. > > As above, this should be described in an imperative mood, and describe why > this is a good change and should be merged. Maybe something along the > lines of the below? > > In 'hashmap_enable_item_counting()', item is assigned but never > used. This causes a warning on HP NonStop. As the variable is > never used, fix this by just removing it. > > > Signed-off-by: Randall S. Becker > > --- > > hashmap.h | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/hashmap.h b/hashmap.h > > index 7ce79f3..d375d9c 100644 > > --- a/hashmap.h > > +++ b/hashmap.h > > @@ -400,7 +400,6 @@ static inline void > hashmap_disable_item_counting(struct hashmap *map) > > */ > > static inline void hashmap_enable_item_counting(struct hashmap *map) > > { > > - void *item; > > unsigned int n = 0; > > struct hashmap_iter iter; > > > > @@ -408,7 +407,7 @@ static inline void > hashmap_enable_item_counting(struct hashmap *map) > > return; > > > > hashmap_iter_init(map, &iter); > > - while ((item = hashmap_iter_next(&iter))) > > + while (hashmap_iter_next(&iter)) > > n++; > > > > map->do_count_items = 1; I like it. Do you need this resubmitted? Or should I just learn for next time? Cheers, Randall ``` ## Thomas Gummerer, 2018-01-15 23:59 Subject: Re: [PATCH] Removed unnecessary void* from hashmap.h that caused compile warnings Message-ID: <20180115235943.GM2641@hank> URL: https://gitlist.dev/e/20180115235943.GM2641%40hank In-Reply-To: <007801d38e42$6b6df3b0$4249db10$@nexbridge.com> ``` On 01/15, Randall S. Becker wrote: > On January 15, 2018 3:43 PM, Thomas Gummerer wrote: > > Thanks for your patch! A few nitpicks below: > > > > > Subject: [PATCH] Removed unnecessary void* from hashmap.h that caused > > > compile warnings > > > > From Documentation/SubmittingPatches: > > > > Describe your changes in imperative mood, e.g. "make xyzzy do frotz" > > instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy > > to do frotz", as if you are giving orders to the codebase to change > > its behavior. > > > > I liked the subject Philip suggested in the other thread: "hashmap.h: > > remove unnecessary void*", or maybe "hashmap.h: remove unnecessary > > variable". > > > > On 01/14, randall.s.becker@rogers.com wrote: > > > From: "Randall S. Becker" > > > > > > * hashmap.h: Revised the while loop in the > > hashmap_enable_item_counting > > > to remove unneeded void* item. > > > > As above, this should be described in an imperative mood, and describe why > > this is a good change and should be merged. Maybe something along the > > lines of the below? > > > > In 'hashmap_enable_item_counting()', item is assigned but never > > used. This causes a warning on HP NonStop. As the variable is > > never used, fix this by just removing it. > > > > > Signed-off-by: Randall S. Becker > > > > > > [..snip..] > > > > I like it. Do you need this resubmitted? Or should I just learn for next > time? I think it would be good if you resubmit the patch. These rules tend to be applied quite strictly, as you can also see when looking at the git commit history. So with the updated commit message Junio should just be able to pick it up (unless there's something I missed here as well :)) As a side note, I just noticed the two submissions both had [PATCH] in the title, whereas new submissions should be marked as such using [PATCH v2] etc. as prefix, so it's easier for reviewers to know which version is the newer one. > Cheers, > Randall > ``` ## Junio C Hamano, 2018-01-16 22:28 Subject: Re: [PATCH] Removed unnecessary void* from hashmap.h that caused compile warnings Message-ID: URL: https://gitlist.dev/e/xmqqinc1tp4c.fsf%40gitster.mtv.corp.google.com In-Reply-To: <007801d38e42$6b6df3b0$4249db10$@nexbridge.com> ``` "Randall S. Becker" writes: > I like it. Do you need this resubmitted? Or should I just learn for next > time? I'll queue the attached for today's iteration. Thanks, both. -- >8 -- From: "Randall S. Becker" Date: Sun, 14 Jan 2018 13:07:48 -0500 Subject: [PATCH] hashmap.h: remove unused variable In 'hashmap_enable_item_counting()', item is assigned but never used. This causes a warning on HP NonStop. As the variable is never used, fix this by just removing it. Signed-off-by: Randall S. Becker Helped-by: Thomas Gummerer Signed-off-by: Junio C Hamano --- hashmap.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hashmap.h b/hashmap.h index 7cb29a6aed..c41ce392b7 100644 --- a/hashmap.h +++ b/hashmap.h @@ -402,7 +402,6 @@ static inline void hashmap_disable_item_counting(struct hashmap *map) */ static inline void hashmap_enable_item_counting(struct hashmap *map) { - void *item; unsigned int n = 0; struct hashmap_iter iter; @@ -410,7 +409,7 @@ static inline void hashmap_enable_item_counting(struct hashmap *map) return; hashmap_iter_init(map, &iter); - while ((item = hashmap_iter_next(&iter))) + while (hashmap_iter_next(&iter)) n++; map->do_count_items = 1; -- 2.16.0-rc2-196-ge713b39cb6 ```