# [PATCH] setup.c: fix comment about order of .git directory discovery 2 messages from 2017-12-07 to 2017-12-08. Participants: SZEDER Gábor, Jeff King. Thread: https://gitlist.dev/t/47393 ## SZEDER Gábor, 2017-12-07 08:59 Subject: [PATCH] setup.c: fix comment about order of .git directory discovery Message-ID: <20171207085949.19519-1-szeder.dev@gmail.com> URL: https://gitlist.dev/e/20171207085949.19519-1-szeder.dev%40gmail.com ``` Since gitfiles were introduced in b44ebb19e (Add platform-independent .git "symlink", 2008-02-20) the order of checks during .git directory discovery is: gitfile, gitdir, bare repo. However, that commit did only partially update the in-code comment describing this order, missing the last line which still puts gitdir before gitfile. Signed-off-by: SZEDER Gábor --- setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.c b/setup.c index 03f51e056..b168d25db 100644 --- a/setup.c +++ b/setup.c @@ -921,7 +921,7 @@ static enum discovery_result setup_git_directory_gently_1(struct strbuf *dir, * - ../.git * - ../.git/ * - ../ (bare) - * - ../../.git/ + * - ../../.git * etc. */ one_filesystem = !git_env_bool("GIT_DISCOVERY_ACROSS_FILESYSTEM", 0); -- 2.15.1.338.g53352fef7 ``` ## Jeff King, 2017-12-08 10:02 Subject: Re: [PATCH] setup.c: fix comment about order of .git directory discovery Message-ID: <20171208100214.GB1899@sigill.intra.peff.net> URL: https://gitlist.dev/e/20171208100214.GB1899%40sigill.intra.peff.net In-Reply-To: <20171207085949.19519-1-szeder.dev@gmail.com> ``` On Thu, Dec 07, 2017 at 09:59:49AM +0100, SZEDER Gábor wrote: > Since gitfiles were introduced in b44ebb19e (Add platform-independent > .git "symlink", 2008-02-20) the order of checks during .git directory > discovery is: gitfile, gitdir, bare repo. However, that commit did > only partially update the in-code comment describing this order, > missing the last line which still puts gitdir before gitfile. I was confused at first, because your patch only changes to ".git/" to ".git". So there is no ordering change, only a swapping out of one for the other. But that pushes done the ".git/" into the "etc." which is below. So I think this makes sense. Thanks. -Peff ```