# [PATCH] Git.xs: older perl do not know const char * 3 messages from 2006-07-02 to 2006-07-02. Participants: Johannes Schindelin, Petr Baudis, Junio C Hamano. Thread: https://gitlist.dev/t/4737 ## Johannes Schindelin, 2006-07-02 09:53 Subject: [PATCH] Git.xs: older perl do not know const char * Message-ID: URL: https://gitlist.dev/e/Pine.LNX.4.63.0607021152200.29667%40wbgn013.biozentrum.uni-wuerzburg.de ``` Both of these casts _should_ be safe, since you do not want to muck around with the version or the path anyway. Signed-off-by: Johannes Schindelin --- perl/Git.xs | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/perl/Git.xs b/perl/Git.xs index 51bfac3..c824210 100644 --- a/perl/Git.xs +++ b/perl/Git.xs @@ -59,7 +59,7 @@ BOOT: # /* TODO: xs_call_gate(). See Git.pm. */ -const char * +char * xs_version() CODE: { @@ -69,11 +69,11 @@ OUTPUT: RETVAL -const char * +char * xs_exec_path() CODE: { - RETVAL = git_exec_path(); + RETVAL = (char *)git_exec_path(); } OUTPUT: RETVAL ``` ## Petr Baudis, 2006-07-02 21:52 Subject: Re: [PATCH] Git.xs: older perl do not know const char * Message-ID: <20060702215249.GK29115@pasky.or.cz> URL: https://gitlist.dev/e/20060702215249.GK29115%40pasky.or.cz In-Reply-To: ``` Dear diary, on Sun, Jul 02, 2006 at 11:53:03AM CEST, I got a letter where Johannes Schindelin said that... > Both of these casts _should_ be safe, since you do not want to muck around > with the version or the path anyway. > > Signed-off-by: Johannes Schindelin Acked-by: Petr Baudis It isn't all that great but it seems everything xs does with this is to feed it to sv_setpv() which AFAIK copies it around. -- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ Snow falling on Perl. White noise covering line noise. Hides all the bugs too. -- J. Putnam ``` ## Junio C Hamano, 2006-07-02 22:39 Subject: Re: [PATCH] Git.xs: older perl do not know const char * Message-ID: <7v1wt33a3l.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7v1wt33a3l.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <20060702215249.GK29115@pasky.or.cz> ``` Petr Baudis writes: > Dear diary, on Sun, Jul 02, 2006 at 11:53:03AM CEST, I got a letter > where Johannes Schindelin said that... >> Both of these casts _should_ be safe, since you do not want to muck around >> with the version or the path anyway. >> >> Signed-off-by: Johannes Schindelin > > Acked-by: Petr Baudis > > It isn't all that great but it seems everything xs does with this is to > feed it to sv_setpv() which AFAIK copies it around. Thanks. Already applied but not pushed out yet (I am working on tracking down unrelated breakage in tests). ```