# [PATCH] submodule--helper.c: i18n: add a missing space in message 3 messages from 2017-11-25 to 2017-11-26. Participants: Jean-Noel Avila, Eric Sunshine, Junio C Hamano. Thread: https://gitlist.dev/t/47319 ## Jean-Noel Avila, 2017-11-25 19:55 Subject: [PATCH] submodule--helper.c: i18n: add a missing space in message Message-ID: <20171125195524.29162-1-jn.avila@free.fr> URL: https://gitlist.dev/e/20171125195524.29162-1-jn.avila%40free.fr ``` The message spans over 2 lines but the C conconcatenation does not add the needed space between the two lines. Signed-off-by: Jean-Noel Avila --- builtin/submodule--helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index 2086f0eb0..a5c4a8a69 100644 --- a/builtin/submodule--helper.c +++ b/builtin/submodule--helper.c @@ -623,7 +623,7 @@ static void status_submodule(const char *path, const struct object_id *ce_oid, if (refs_head_ref(get_submodule_ref_store(path), handle_submodule_head_ref, &oid)) - die(_("could not resolve HEAD ref inside the" + die(_("could not resolve HEAD ref inside the " "submodule '%s'"), path); print_status(flags, '+', path, &oid, displaypath); -- 2.15.0 ``` ## Eric Sunshine, 2017-11-25 23:51 Subject: Re: [PATCH] submodule--helper.c: i18n: add a missing space in message Message-ID: URL: https://gitlist.dev/e/CAPig%2BcTZcS0nk-grQaN7kXxJMRELd6fuhS459FtVVeOV1ZYODw%40mail.gmail.com In-Reply-To: <20171125195524.29162-1-jn.avila@free.fr> ``` On Sat, Nov 25, 2017 at 2:55 PM, Jean-Noel Avila wrote: > The message spans over 2 lines but the C conconcatenation does not add s/conconcatenation/concatenation/ > the needed space between the two lines. > > Signed-off-by: Jean-Noel Avila > --- > diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c > index 2086f0eb0..a5c4a8a69 100644 > --- a/builtin/submodule--helper.c > +++ b/builtin/submodule--helper.c > @@ -623,7 +623,7 @@ static void status_submodule(const char *path, const struct object_id *ce_oid, > > if (refs_head_ref(get_submodule_ref_store(path), > handle_submodule_head_ref, &oid)) > - die(_("could not resolve HEAD ref inside the" > + die(_("could not resolve HEAD ref inside the " > "submodule '%s'"), path); > > print_status(flags, '+', path, &oid, displaypath); > -- > 2.15.0 ``` ## Junio C Hamano, 2017-11-26 03:52 Subject: Re: [PATCH] submodule--helper.c: i18n: add a missing space in message Message-ID: URL: https://gitlist.dev/e/xmqqfu91itnb.fsf%40gitster.mtv.corp.google.com In-Reply-To: <20171125195524.29162-1-jn.avila@free.fr> ``` Thanks. ```