threads / patch / 47317

patchRelNotes: minor typo fixes in 2.15.1 draft

Subject: [PATCH] RelNotes: minor typo fixes in 2.15.1 draft

## tl;dr

3 messages between Nov 25, 2017 and Nov 26, 2017. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Todd Zullinger· Nov 25, 2017, 17:33 UTC · lore

Signed-off-by: Todd Zullinger <tmz@pobox.com>
---
 Documentation/RelNotes/2.15.1.txt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Show changes to Documentation/RelNotes/2.15.1.txt +3 −3

diff --git a/Documentation/RelNotes/2.15.1.txt b/Documentation/RelNotes/2.15.1.txt
index 47f23b56fe..81dd64b4ad 100644
--- a/Documentation/RelNotes/2.15.1.txt
+++ b/Documentation/RelNotes/2.15.1.txt
@@ -13,7 +13,7 @@ Fixes since v2.15
    latter, which has been fixed.
 
  * The experimental "color moved lines differently in diff output"
-   feature was buggy around "ignore whitespace changes" edges, whihch
+   feature was buggy around "ignore whitespace changes" edges, which
    has been corrected.
 
  * Instead of using custom line comparison and hashing functions to
@@ -24,7 +24,7 @@ Fixes since v2.15
    HEAD points at, which have been fixed.
 
  * "git commit", after making a commit, did not check for errors when
-   asking on what branch it made the commit, which has been correted.
+   asking on what branch it made the commit, which has been corrected.
 
  * "git status --ignored -u" did not stop at a working tree of a
    separate project that is embedded in an ignored directory and
@@ -35,7 +35,7 @@ Fixes since v2.15
    --recurse-submodules" has been fixed.
 
  * A recent regression in "git rebase -i" that broke execution of git
-   commands from subdirectories via "exec" insn has been fixed.
+   commands from subdirectories via "exec" instruction has been fixed.
 
  * "git check-ref-format --branch @{-1}" bit a "BUG()" when run
    outside a repository for obvious reasons; clarify the documentation

-- 
2.15.0

Todd Zullinger· Nov 25, 2017, 18:02 UTC · re: Todd Zullinger · lore

Re: [PATCH] RelNotes: minor typo fixes in 2.15.1 draft

Apologies for the duplicate. I used the `-n` option, mistakenly thinking it was a synonym for `--dry-run` and didn't pay enough attention to see that it sent. (The only indication is s/OK./Dry &/ which I missed.)

It was mildly surprising that the script didn't warn or complain about an unknown option. After a quick look, that seems to be due to the Getopt::Long pass_through option which sends unknown options to format-patch.

That doesn't remove the user-error on my part, of course. ;)

-- 
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Cogito cogito ergo cogito sum --
I think that I think, therefore I think that I am.
    -- Ambrose Bierce, "The Devil's Dictionary"

Junio C Hamano· Nov 26, 2017, 03:49 UTC · re: Todd Zullinger · lore

Re: [PATCH] RelNotes: minor typo fixes in 2.15.1 draft

Todd Zullinger <tmz@pobox.com> writes:

> It was mildly surprising that the script didn't warn or complain about
> an unknown option.  After a quick look, that seems to be due to the
> Getopt::Long pass_through option which sends unknown options to
> format-patch.

Heh, that is another reason why I recommend against letting send-email run format-patch from within (another a lot bigger one is that running them seprately gives you a chance to look and proofread the output from format-patch one more time before actually sending them out, which also allows you to update additional comments after the three-dash lines).