threads / patch / 47113

patchfix an 'dubious one-bit signed bitfield' error

Subject: [PATCH] fix an 'dubious one-bit signed bitfield' error

## tl;dr

2 messages between Nov 3, 2017 and Nov 3, 2017. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Ramsay Jones· Nov 3, 2017, 17:05 UTC · lore
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Jeff,

If you need to re-roll your 'jh/object-filtering' branch, could you please squash this into the relevant commit (b87fd93d81, "list-objects: filter objects in traverse_commit_list", 02-11-2017).

[This error was issued by sparse]
Thanks!

ATB, Ramsay Jones

 list-objects-filter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to list-objects-filter.c +1 −1
diff --git a/list-objects-filter.c b/list-objects-filter.c
index 7f2842547..d9e626be8 100644
--- a/list-objects-filter.c
+++ b/list-objects-filter.c
@@ -191,7 +191,7 @@ static void *filter_blobs_limit__init(
  */
 struct frame {
 	int defval;
-	int child_prov_omit : 1;
+	unsigned int child_prov_omit : 1;
 };
 
 struct filter_sparse_data {
-- 
2.15.0
Jeff Hostetler· Nov 3, 2017, 17:26 UTC · re: Ramsay Jones · lore

Re: [PATCH] fix an 'dubious one-bit signed bitfield' error

d'oh.  thanks!
On 11/3/2017 1:05 PM, Ramsay Jones wrote:
Show 34 quoted lines
> 
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
> 
> Hi Jeff,
> 
> If you need to re-roll your 'jh/object-filtering' branch, could
> you please squash this into the relevant commit (b87fd93d81,
> "list-objects: filter objects in traverse_commit_list", 02-11-2017).
> 
> [This error was issued by sparse]
> 
> Thanks!
> 
> ATB,
> Ramsay Jones
> 
>   list-objects-filter.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/list-objects-filter.c b/list-objects-filter.c
> index 7f2842547..d9e626be8 100644
> --- a/list-objects-filter.c
> +++ b/list-objects-filter.c
> @@ -191,7 +191,7 @@ static void *filter_blobs_limit__init(
>    */
>   struct frame {
>   	int defval;
> -	int child_prov_omit : 1;
> +	unsigned int child_prov_omit : 1;
>   };
>   
>   struct filter_sparse_data {
> 

← back to recent threads