# [PATCH (fixed) 1/2] rebase: check for errors from git-commit

1 messages from 2006-06-28 to 2006-06-28. Participants: Eric Wong.
Thread: https://gitlist.dev/t/4695

## Eric Wong, 2006-06-28 10:24

Subject: [PATCH (fixed) 1/2] rebase: check for errors from git-commit
Message-ID: <20060628102423.GA25093@soma>
URL: https://gitlist.dev/e/20060628102423.GA25093%40soma

```
commit does not always succeed, so we'll have to check for
it in the absence of set -e.  This fixes a regression
introduced in 9e4bc7dd1bb9d92491c475cec55147fa0b3f954d

Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
 git-rebase.sh |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/git-rebase.sh b/git-rebase.sh
index 9ad1c44..28860fc 100755
--- a/git-rebase.sh
+++ b/git-rebase.sh
@@ -59,8 +59,13 @@ continue_merge () {
 
 	if test -n "`git-diff-index HEAD`"
 	then
+		if ! git-commit -C "`cat $dotest/current`"
+		then
+			echo "Commit failed, please do not call \"git commit\""
+			echo "directly, but instead do one of the following: "
+			die "$RESOLVEMSG"
+		fi
 		printf "Committed: %0${prec}d" $msgnum
-		git-commit -C "`cat $dotest/current`"
 	else
 		printf "Already applied: %0${prec}d" $msgnum
 	fi
-- 
1.4.1.rc1.gc7c5

```