threads / discuss / 46929

git add --patch displays diff and exits

Subject: git add --patch displays diff and exits

## tl;dr

3 messages between Oct 6, 2017 and Oct 6, 2017.

replies: 2people: 2as markdown or json

Jake Bell· Oct 6, 2017, 18:09 UTC · lore

Hello,

I'm not sure if this is the right place to report this issue, so apologies in advance if it isn't.

Recently, I upgraded from git 2.14.1 to 2.14.2, and noticed that "git add --patch" does not work properly. It just prints a diff of what's changed and exits, instead of presenting the dialogs to add changes to the index. I did some bisecting and tracked the bug down to this commit: https://github.com/git/git/commit/136c8c8b8fa39f1315713248473dececf20f8fe7.

Unfortunately, I'm not familiar with the codebase and don't know C well enough to debug the issue. Please let me know what additional information I can provide to help you all figure it out. Thanks!

-- Jake

Stefan Beller· Oct 6, 2017, 18:13 UTC · re: Jake Bell · lore

Re: git add --patch displays diff and exits

On Fri, Oct 6, 2017 at 11:09 AM, Jake Bell <jake@theunraveler.com> wrote:

Show 8 quoted lines

> Hello,
>
> I'm not sure if this is the right place to report this issue, so apologies in advance if it isn't.
>
> Recently, I upgraded from git 2.14.1 to 2.14.2, and noticed that "git add --patch" does not work properly. It just prints a diff of what's changed and exits, instead of presenting the dialogs to add changes to the index. I did some bisecting and tracked the bug down to this commit: https://github.com/git/git/commit/136c8c8b8fa39f1315713248473dececf20f8fe7.
>
> Unfortunately, I'm not familiar with the codebase and don't know C well enough to debug the issue. Please let me know what additional information I can provide to help you all figure it out.
> Thanks!

Please see https://public-inbox.org/git/20171003093157.gq7za2fwcqsouire@sigill.intra.peff.net/T/ and replace the color=always by color=auto setting to see if it fixes your problem. (If it doesn't we're dealing with a new problem and not the one reported more than 5 times already :)

Thanks, Stefan

>
> -- Jake
>

Jake Bell· Oct 6, 2017, 18:13 UTC · lore

Re: git add --patch displays diff and exits

Sorry, please disregard---this is a duplicate of some other messages already sent to the list. Setting "color.ui = auto" fixed the issue for me.

-- Jake

Show 21 quoted lines

> On Oct 6, 2017, at 1:13 PM, Jake Bell <jake@theunraveler.com> wrote:
> 
> Sorry, please disregard---this is a duplicate of some other messages already sent to the list. Setting "color.ui = auto" fixed the issue for me.
> 
> 
> -- Jake
> 
>> On Oct 6, 2017, at 1:09 PM, Jake Bell <jake@theunraveler.com> wrote:
>> 
>> Hello,
>> 
>> I'm not sure if this is the right place to report this issue, so apologies in advance if it isn't.
>> 
>> Recently, I upgraded from git 2.14.1 to 2.14.2, and noticed that "git add --patch" does not work properly. It just prints a diff of what's changed and exits, instead of presenting the dialogs to add changes to the index. I did some bisecting and tracked the bug down to this commit: https://github.com/git/git/commit/136c8c8b8fa39f1315713248473dececf20f8fe7.
>> 
>> Unfortunately, I'm not familiar with the codebase and don't know C well enough to debug the issue. Please let me know what additional information I can provide to help you all figure it out.
>> Thanks!
>> 
>> -- Jake
>> 
>