couple questions about git "logical variables" and "git var"

   i just ran across "git var" for the first time, and it seems a bit weird.
it refers to the (apparently) four git "logical variables":

  - GIT_AUTHOR_IDENT
  - GIT_COMMITTER_IDENT
  - GIT_EDITOR
  - GIT_PAGER

first question -- what is it about precisely those four variables that makes them "logical" variables in git parlance? just those four? no others?

   also, the man page "man git-var" seems wrong:

"OPTIONS
   -l
     Cause the logical variables to be listed. In addition, all the variables
     of the Git configuration file .git/config are listed as well."

no, if i run "git var -l", i see not only the logical variables, but i see *all* of the available config settings (system and global), not just those in .git/config (unless i'm misreading what that is supposed to mean).

   thoughts?

rday

p.s. yes, i realize this command is deprecated in favour of "git config -l", but as long as it's available, it should work as described in the man page.

On Thu, Oct 05, 2017 at 05:11:04AM -0400, rpjday@crashcourse.ca wrote:

It's definitely weird.

It was introduced in the very early days as a way for scripts to get access to "standard" values that would be computed the same way as the C portions of Git. But it hasn't generally been kept up to date with new possible variables.

It also only tells half the story. You have to know not just what's in $GIT_EDITOR, but you have to know the right way to evaluate it. There's a git_editor helper in git-sh-setup, but other scripting languages are on their own. We'd probably have done better to introduce a "git editor" command which can be run from any language.

But as most of Git is written in C these days, it seems that nobody had enough interest to smooth out these kinds of rough edges.

Yes, I agree the description there is wrong. I'd have to dig in the history to be sure, but I'm pretty sure it has _always_ been wrong.

Yes, though I think fixing the manpage is the right way to make them consistent.

-Peff

Jeff King wrote:

I am not sure I understand the complaint here.  git-var(1) says:

	GIT_EDITOR
	   Text editor for use by Git commands. The value is meant to be
	   interpreted by the shell when it is used. Examples: [...]

Are you saying that the output of the command should quote that manpage, so as to tell the rest of the story?

I remember that we discussed this at the time but don't remember why it didn't happen. It seems like a good idea.

[...]

Agreed as well.  rday, care to take a stab at wording?

Thanks, Jonathan

On Thu, Oct 05, 2017 at 07:35:30PM -0700, Jonathan Nieder wrote:

No, I just meant that after reading that manpage, I'm not sure I would have picked up the subtlety that shell scripts need to call:

  eval "$GIT_EDITOR" '"$@"'

and not:

  "$GIT_EDITOR" "$@"

or:

  $GIT_EDITOR "$@"

(And likewise, other languages need to make sure they run "sh -c ..." and not a straight spawn/exec of the editor command).

If the command were instead:

  git editor "$@"

that's harder to get wrong.

-Peff