threads / patch / 46866

patchpath: use strbuf_add_real_path()

Subject: [PATCH] path: use strbuf_add_real_path()

## tl;dr

One message between Oct 1, 2017 and Oct 1, 2017. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

René Scharfe· Oct 1, 2017, 14:44 UTC · lore

Avoid a string copy to a static buffer by using strbuf_add_real_path() instead of combining strbuf_addstr() and real_path().

Patch generated by Coccinelle and contrib/coccinelle/strbuf.cocci.
Signed-off-by: Rene Scharfe <l.s.r@web.de>
---
 path.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to path.c +1 −1
diff --git a/path.c b/path.c
index b533ec938d..bf096c411c 100644
--- a/path.c
+++ b/path.c
@@ -717,7 +717,7 @@ char *expand_user_path(const char *path, int real_home)
 			if (!home)
 				goto return_null;
 			if (real_home)
-				strbuf_addstr(&user_path, real_path(home));
+				strbuf_add_real_path(&user_path, home);
 			else
 				strbuf_addstr(&user_path, home);
 #ifdef GIT_WINDOWS_NATIVE
-- 
2.14.2

← back to recent threads