threads / patch / 46770

patcht2018: remove unwanted empty line

Subject: [PATCH] t2018: remove unwanted empty line

## tl;dr

3 messages between Sep 17, 2017 and Sep 18, 2017. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Kaartic Sivaraam· Sep 17, 2017, 10:19 UTC · lore

Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
---
 t/t2018-checkout-branch.sh | 1 -
 1 file changed, 1 deletion(-)

Show changes to t/t2018-checkout-branch.sh +0 −2

diff --git a/t/t2018-checkout-branch.sh b/t/t2018-checkout-branch.sh
index 2131fb2a5682c..e0a52334a22dd 100755
--- a/t/t2018-checkout-branch.sh
+++ b/t/t2018-checkout-branch.sh
@@ -192,7 +192,6 @@ test_expect_success 'checkout -b <describe>' '
 test_expect_success 'checkout -B to the current branch works' '
 	git checkout branch1 &&
 	git checkout -B branch1-scratch &&
-
 	setup_dirty_mergeable &&
 	git checkout -B branch1-scratch initial &&
 	test_dirty_mergeable

--
https://github.com/git/git/pull/403

Kevin Daudt· Sep 17, 2017, 19:22 UTC · re: Kaartic Sivaraam · lore

Re: [PATCH] t2018: remove unwanted empty line

On Sun, Sep 17, 2017 at 10:19:28AM +0000, Kaartic Sivaraam wrote:

Show 20 quoted lines

> Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
> ---
>  t/t2018-checkout-branch.sh | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/t/t2018-checkout-branch.sh b/t/t2018-checkout-branch.sh
> index 2131fb2a5682c..e0a52334a22dd 100755
> --- a/t/t2018-checkout-branch.sh
> +++ b/t/t2018-checkout-branch.sh
> @@ -192,7 +192,6 @@ test_expect_success 'checkout -b <describe>' '
>  test_expect_success 'checkout -B to the current branch works' '
>  	git checkout branch1 &&
>  	git checkout -B branch1-scratch &&
> -
>  	setup_dirty_mergeable &&
>  	git checkout -B branch1-scratch initial &&
>  	test_dirty_mergeable
> 
> --
> https://github.com/git/git/pull/403

Why is this empty line unwanted? This kind of whitespace can help separate logical sections, just like paragraphs would.

Kevin.

Kaartic Sivaraam· Sep 18, 2017, 13:37 UTC · re: Kevin Daudt · lore

Re: [PATCH] t2018: remove unwanted empty line

On Monday 18 September 2017 12:52 AM, Kevin Daudt wrote:

> Why is this empty line unwanted? This kind of whitespace can help
> separate logical sections, just like paragraphs would.
>

You're right. I seem to have sent a fix precariously because I haven't such separation before (forgetting the fact that git has contributors whose way of writing test vary diversly). Should better stop back and think the next time rather than spamming the list. Sorry, for this.

--- Kaartic