# [PATCH] usage: conditionally compile unleak_memory() definition

2 messages from 2017-09-07 to 2017-09-08. Participants: Ramsay Jones, Jeff King.
Thread: https://gitlist.dev/t/46722

## Ramsay Jones, 2017-09-07 16:08

Subject: [PATCH] usage: conditionally compile unleak_memory() definition
Message-ID: <1cf112f5-aad1-e1c6-b507-9524f4b72fec@ramsayjones.plus.com>
URL: https://gitlist.dev/e/1cf112f5-aad1-e1c6-b507-9524f4b72fec%40ramsayjones.plus.com

```

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---

Hi Jeff,

If you need to re-roll your 'jk/leak-checkers' branch, could you
please squash this into the relevant patch (commit c57586d954,
"add UNLEAK annotation for reducing leak false positives", 05-09-2017).

This was noticed by sparse, since it is not declared when the
SUPPRESS_ANNOTATED_LEAKS pre-processor macro is not defined.
(You could move the declaration out of the #ifdef in the header
file, I suppose, but it seems pointless to compile the function
if it isn't being used).

Thanks!

ATB,
Ramsay Jones

 usage.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/usage.c b/usage.c
index 780ed73be..cdd534c9d 100644
--- a/usage.c
+++ b/usage.c
@@ -242,6 +242,7 @@ NORETURN void BUG(const char *fmt, ...)
 }
 #endif
 
+#ifdef SUPPRESS_ANNOTATED_LEAKS
 void unleak_memory(const void *ptr, size_t len)
 {
 	static struct suppressed_leak_root {
@@ -254,3 +255,4 @@ void unleak_memory(const void *ptr, size_t len)
 	root->next = suppressed_leaks;
 	suppressed_leaks = root;
 }
+#endif
-- 
2.14.0

```

## Jeff King, 2017-09-08 03:37

Subject: Re: [PATCH] usage: conditionally compile unleak_memory() definition
Message-ID: <20170908033733.r3c2akrtbk5wvqad@sigill.intra.peff.net>
URL: https://gitlist.dev/e/20170908033733.r3c2akrtbk5wvqad%40sigill.intra.peff.net
In-Reply-To: <1cf112f5-aad1-e1c6-b507-9524f4b72fec@ramsayjones.plus.com>

```
On Thu, Sep 07, 2017 at 05:08:23PM +0100, Ramsay Jones wrote:

> Hi Jeff,
> 
> If you need to re-roll your 'jk/leak-checkers' branch, could you
> please squash this into the relevant patch (commit c57586d954,
> "add UNLEAK annotation for reducing leak false positives", 05-09-2017).
> 
> This was noticed by sparse, since it is not declared when the
> SUPPRESS_ANNOTATED_LEAKS pre-processor macro is not defined.
> (You could move the declaration out of the #ifdef in the header
> file, I suppose, but it seems pointless to compile the function
> if it isn't being used).

Thanks, that makes sense. There are a handful of other bits to modify in
that final commit, so I will end up with at least one re-roll.

-Peff

```