# [PATCH] Add t/helper/test-write-cache to .gitignore 3 messages from 2017-08-28 to 2017-09-20. Participants: Jonathan Tan, Brandon Williams, Jonathan Nieder. Thread: https://gitlist.dev/t/46678 ## Jonathan Tan, 2017-08-28 20:06 Subject: [PATCH] Add t/helper/test-write-cache to .gitignore Message-ID: <20170828200618.27569-1-jonathantanmy@google.com> URL: https://gitlist.dev/e/20170828200618.27569-1-jonathantanmy%40google.com ``` This new binary was introduced in commit 3921a0b ("perf: add test for writing the index", 2017-08-21), but a .gitignore entry was not added for it. Add that entry. Signed-off-by: Jonathan Tan --- t/helper/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/t/helper/.gitignore b/t/helper/.gitignore index 721650256..7c9d28a83 100644 --- a/t/helper/.gitignore +++ b/t/helper/.gitignore @@ -35,3 +35,4 @@ /test-svn-fe /test-urlmatch-normalization /test-wildmatch +/test-write-cache -- 2.14.1.581.gf28d330327-goog ``` ## Brandon Williams, 2017-08-28 21:09 Subject: Re: [PATCH] Add t/helper/test-write-cache to .gitignore Message-ID: <20170828210939.GA71562@google.com> URL: https://gitlist.dev/e/20170828210939.GA71562%40google.com In-Reply-To: <20170828200618.27569-1-jonathantanmy@google.com> ``` On 08/28, Jonathan Tan wrote: > This new binary was introduced in commit 3921a0b ("perf: add test for > writing the index", 2017-08-21), but a .gitignore entry was not added > for it. Add that entry. > > Signed-off-by: Jonathan Tan Looks good to me > --- > t/helper/.gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/t/helper/.gitignore b/t/helper/.gitignore > index 721650256..7c9d28a83 100644 > --- a/t/helper/.gitignore > +++ b/t/helper/.gitignore > @@ -35,3 +35,4 @@ > /test-svn-fe > /test-urlmatch-normalization > /test-wildmatch > +/test-write-cache > -- > 2.14.1.581.gf28d330327-goog > -- Brandon Williams ``` ## Jonathan Nieder, 2017-09-20 18:47 Subject: Re: [PATCH] Add t/helper/test-write-cache to .gitignore Message-ID: <20170920184753.GC27425@aiede.mtv.corp.google.com> URL: https://gitlist.dev/e/20170920184753.GC27425%40aiede.mtv.corp.google.com In-Reply-To: <20170828210939.GA71562@google.com> ``` Brandon Williams wrote: > On 08/28, Jonathan Tan wrote: >> This new binary was introduced in commit 3921a0b ("perf: add test for >> writing the index", 2017-08-21), but a .gitignore entry was not added >> for it. Add that entry. >> >> Signed-off-by: Jonathan Tan > > Looks good to me Reviewed-by: Jonathan Nieder as well. I wonder if we can automate this a little. Some thoughts: A. We could include a test that all the binaries named in TEST_PROGRAMS_NEED_X are also named in t/helper/.gitignore. That way tests would fail if this ever falls out of date again. B. Even better would be if we could have /t/helper/test-* in .gitignore. E.g. if we rename test-*.c to *.c (e.g. t/helper/ctype.c instead of t/helper/test-ctype.c), then the test helper source file names would be easier to type and maintaining this .gitignore would become a problem of the past. What do you think? Jonathan ```