# [PATCH] vcs-svn/repo_tree.h: remove repo_init declaration 6 messages from 2017-08-22 to 2017-08-23. Participants: Stefan Beller, Junio C Hamano, Jonathan Nieder. Thread: https://gitlist.dev/t/46652 ## Stefan Beller, 2017-08-22 21:35 Subject: [PATCH] vcs-svn/repo_tree.h: remove repo_init declaration Message-ID: <20170822213501.5928-1-sbeller@google.com> URL: https://gitlist.dev/e/20170822213501.5928-1-sbeller%40google.com ``` The svn specific declaration of repo_init was not used since 723b7a2789 (vcs-svn: eliminate repo_tree structure, 2010-12-10). This was noticed when including repository.h via cache.h as that has the same function with a different signature. Helped-by: Jonathan Nieder Signed-off-by: Stefan Beller --- vcs-svn/repo_tree.h | 1 - 1 file changed, 1 deletion(-) diff --git a/vcs-svn/repo_tree.h b/vcs-svn/repo_tree.h index 889c6a3c95..8592beb59b 100644 --- a/vcs-svn/repo_tree.h +++ b/vcs-svn/repo_tree.h @@ -17,7 +17,6 @@ void repo_commit(uint32_t revision, const char *author, const struct strbuf *log, const char *uuid, const char *url, long unsigned timestamp); void repo_diff(uint32_t r1, uint32_t r2); -void repo_init(void); void repo_reset(void); #endif -- 2.14.0.rc0.3.g6c2e499285 ``` ## Junio C Hamano, 2017-08-22 22:18 Subject: Re: [PATCH] vcs-svn/repo_tree.h: remove repo_init declaration Message-ID: URL: https://gitlist.dev/e/xmqqmv6r1c26.fsf%40gitster.mtv.corp.google.com In-Reply-To: <20170822213501.5928-1-sbeller@google.com> ``` Stefan Beller writes: > The svn specific declaration of repo_init was not used since 723b7a2789 > (vcs-svn: eliminate repo_tree structure, 2010-12-10). > > This was noticed when including repository.h via cache.h as that has the > same function with a different signature. > > Helped-by: Jonathan Nieder > Signed-off-by: Stefan Beller > --- It looks to me that this is a reduced duplicate of what brian posted yesterday. The first two patches in the 6-patch series that you commented on, I think, covers what this change wants to achieve and probably a lot more. I've merged those two already to 'next' and was about to push the result out. Thanks. > vcs-svn/repo_tree.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/vcs-svn/repo_tree.h b/vcs-svn/repo_tree.h > index 889c6a3c95..8592beb59b 100644 > --- a/vcs-svn/repo_tree.h > +++ b/vcs-svn/repo_tree.h > @@ -17,7 +17,6 @@ void repo_commit(uint32_t revision, const char *author, > const struct strbuf *log, const char *uuid, const char *url, > long unsigned timestamp); > void repo_diff(uint32_t r1, uint32_t r2); > -void repo_init(void); > void repo_reset(void); > > #endif ``` ## Stefan Beller, 2017-08-22 22:24 Subject: Re: [PATCH] vcs-svn/repo_tree.h: remove repo_init declaration Message-ID: URL: https://gitlist.dev/e/CAGZ79kbMc%2BkVsc2-fBfOHVZvvABWnDpQfs-hqLCxb2FTTr8YCQ%40mail.gmail.com In-Reply-To: ``` On Tue, Aug 22, 2017 at 3:18 PM, Junio C Hamano wrote: > Stefan Beller writes: > > >> The svn specific declaration of repo_init was not used since 723b7a2789 >> (vcs-svn: eliminate repo_tree structure, 2010-12-10). >> >> This was noticed when including repository.h via cache.h as that has the >> same function with a different signature. >> >> Helped-by: Jonathan Nieder >> Signed-off-by: Stefan Beller >> --- > > It looks to me that this is a reduced duplicate of what brian posted > yesterday. The first two patches in the 6-patch series that you > commented on, I think, covers what this change wants to achieve and > probably a lot more. I've merged those two already to 'next' and > was about to push the result out. > > Thanks. > Ok, thanks. I did not remember reviewing those. (I just wanted to fix my odd compile error here, and currently I build a series on top of jt/packmigrate so I shot off a quick one liner) Sorry for the noise. ``` ## Jonathan Nieder, 2017-08-22 22:54 Subject: Re: [PATCH] vcs-svn/repo_tree.h: remove repo_init declaration Message-ID: <20170822225405.GV13924@aiede.mtv.corp.google.com> URL: https://gitlist.dev/e/20170822225405.GV13924%40aiede.mtv.corp.google.com In-Reply-To: ``` Junio C Hamano wrote: > Stefan Beller writes: >> The svn specific declaration of repo_init was not used since 723b7a2789 >> (vcs-svn: eliminate repo_tree structure, 2010-12-10). >> >> This was noticed when including repository.h via cache.h as that has the >> same function with a different signature. >> >> Helped-by: Jonathan Nieder >> Signed-off-by: Stefan Beller > > It looks to me that this is a reduced duplicate of what brian posted > yesterday. The first two patches in the 6-patch series that you > commented on, I think, covers what this change wants to achieve and > probably a lot more. I've merged those two already to 'next' and > was about to push the result out. Thanks for the pointer. I believe you're referring to https://public-inbox.org/git/20170821000022.26729-2-sandals@crustytoothpaste.net/. From Stefan's verbal report I was about to send a patch just like Brian's plus some more patches on top to get rid of the rest of repo_tree.h. I can build on top of Brian's patch if that's more convenient. Regards, Jonathan ``` ## Jonathan Nieder, 2017-08-22 23:45 Subject: Re: [PATCH] vcs-svn/repo_tree.h: remove repo_init declaration Message-ID: <20170822234553.GC13924@aiede.mtv.corp.google.com> URL: https://gitlist.dev/e/20170822234553.GC13924%40aiede.mtv.corp.google.com In-Reply-To: ``` Junio C Hamano wrote: > Stefan Beller writes: >> The svn specific declaration of repo_init was not used since 723b7a2789 >> (vcs-svn: eliminate repo_tree structure, 2010-12-10). >> >> This was noticed when including repository.h via cache.h as that has the >> same function with a different signature. >> >> Helped-by: Jonathan Nieder >> Signed-off-by: Stefan Beller >> --- > > It looks to me that this is a reduced duplicate of what brian posted > yesterday. The first two patches in the 6-patch series that you > commented on, I think, covers what this change wants to achieve and > probably a lot more. I've merged those two already to 'next' and > was about to push the result out. I just sent https://public-inbox.org/git/20170822233732.GX13924@aiede.mtv.corp.google.com/ to fix this more thoroughly. I can rebase on top of bc/vcs-svn-cleanup if that is helpful --- just say the word. Thanks, Jonathan ``` ## Junio C Hamano, 2017-08-23 01:10 Subject: Re: [PATCH] vcs-svn/repo_tree.h: remove repo_init declaration Message-ID: URL: https://gitlist.dev/e/xmqqa82r1441.fsf%40gitster.mtv.corp.google.com In-Reply-To: <20170822234553.GC13924@aiede.mtv.corp.google.com> ``` Jonathan Nieder writes: > Junio C Hamano wrote: > ... >> It looks to me that this is a reduced duplicate of what brian posted >> yesterday. The first two patches in the 6-patch series that you >> commented on, I think, covers what this change wants to achieve and >> probably a lot more. I've merged those two already to 'next' and >> was about to push the result out. > > I just sent > https://public-inbox.org/git/20170822233732.GX13924@aiede.mtv.corp.google.com/ > to fix this more thoroughly. I can rebase on top of bc/vcs-svn-cleanup > if that is helpful --- just say the word. Yup, as I merged those two preliminary clean-up separately to 'next' already, it would be more efficient to build on top. I do not know what you are planning with the other patches (I only saw Stefan's one, not your series) so do not yet have suggestion on how to work well with Brian's series that builds on his two clean-up patches. Hopefully they are orthogonal? Thanks. ```