threads / discuss / 46646

mk-dontmerge/size-t-on-next test failure

Subject: mk-dontmerge/size-t-on-next test failure

## tl;dr

2 messages between Aug 22, 2017 and Aug 22, 2017.

replies: 1people: 2as markdown or json

Johannes Sixt· Aug 22, 2017, 17:06 UTC · lore

I observe the test failure below in t0040-parse-options.sh. It bisects to 1a7909b25eb4ab3071ce4290115618e2582eadaa "Convert pack-objects to size_t". It looks like git_parse_size_t() needs a fix. This is on Windows, 32 bit. size_t, int and long are all 32 bits wide.

expecting success:
        check magnitude: 1073741824 -m 1g
ok 18 - OPT_MAGNITUDE() giga
expecting success:
        check magnitude: 3221225472 -m 3g

error: switch `m' expects a non-negative integer value with an optional k/m/g suffix usage: test-parse-options <options>

    --yes                 get a boolean
    -D, --no-doubt        begins with 'no-'
    -B, --no-fear         be brave
    -b, --boolean         increment by one
    -4, --or4             bitwise-or boolean with ...0100
    --neg-or4             same as --no-or4
    -i, --integer <n>     get a integer
    -j <n>                get a integer, too
    -m, --magnitude <n>   get a magnitude
    --set23               set integer to 23
    -t <time>             get timestamp of <time>
    -L, --length <str>    get length of <str>
    -F, --file <file>     set file to <file>
String options
    -s, --string <string>
                          get a string
    --string2 <str>       get another string
    --st <st>             get another string (pervert ordering)
    -o <str>              get another string
    --list <str>          add str to list
Magic arguments
    --quux                means --quux
    -NUM                  set integer to NUM
    +                     same as -b
    --ambiguous           positive ambiguity
    --no-ambiguous        negative ambiguity
Standard options
    --abbrev[=<n>]        use <n> digits to display SHA-1s
    -v, --verbose         be verbose
    -n, --dry-run         dry run
    -q, --quiet           be quiet
    --expect <string>     expected output in the variable dump

not ok 19 - OPT_MAGNITUDE() 3giga # # check magnitude: 3221225472 -m 3g #

Junio C Hamano· Aug 22, 2017, 19:24 UTC · re: Johannes Sixt · lore

Re: mk-dontmerge/size-t-on-next test failure

Johannes Sixt <j6t@kdbg.org> writes:
> I observe the test failure below in t0040-parse-options.sh. It bisects
> to 1a7909b25eb4ab3071ce4290115618e2582eadaa "Convert pack-objects to
> size_t". It looks like git_parse_size_t() needs a fix. This is on
> Windows, 32 bit. size_t, int and long are all 32 bits wide.

Thanks. It is very much appreciated for people to peek at the branch and try on different platforms that I (or Martin) do not use regularly.

← back to recent threads