# [PATCH] commit: remove unused inline function single_parent()

2 messages from 2017-08-19 to 2017-08-19. Participants: René Scharfe, Junio C Hamano.
Thread: https://gitlist.dev/t/46625

## René Scharfe, 2017-08-19 08:12

Subject: [PATCH] commit: remove unused inline function single_parent()
Message-ID: <0993ee6c-712b-505e-9cfc-364d7ab71261@web.de>
URL: https://gitlist.dev/e/0993ee6c-712b-505e-9cfc-364d7ab71261%40web.de

```
53b2c823f6 (revision walker: mini clean-up) added the function in 2007,
but it was never used, so we should be able to get rid of it now.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
---
 commit.h | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/commit.h b/commit.h
index 6d857f06c1..1283d2a51f 100644
--- a/commit.h
+++ b/commit.h
@@ -313,11 +313,6 @@ extern int interactive_add(int argc, const char **argv, const char *prefix, int
 extern int run_add_interactive(const char *revision, const char *patch_mode,
 			       const struct pathspec *pathspec);
 
-static inline int single_parent(struct commit *commit)
-{
-	return commit->parents && !commit->parents->next;
-}
-
 struct commit_list *reduce_heads(struct commit_list *heads);
 
 struct commit_extra_header {
-- 
2.14.1

```

## Junio C Hamano, 2017-08-19 16:50

Subject: Re: [PATCH] commit: remove unused inline function single_parent()
Message-ID: <xmqq7exza4d5.fsf@gitster.mtv.corp.google.com>
URL: https://gitlist.dev/e/xmqq7exza4d5.fsf%40gitster.mtv.corp.google.com
In-Reply-To: <0993ee6c-712b-505e-9cfc-364d7ab71261@web.de>

```
Thanks.

```
