threads / patch / 46279

patcht1450: use egrep for regexp "alternation"

Subject: [PATCH] t1450: use egrep for regexp "alternation"

## tl;dr

One message between Jun 28, 2017 and Jun 28, 2017. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Junio C Hamano· Jun 28, 2017, 17:17 UTC · lore

GNU grep allows "\(A\|B\)" as alternation in BRE, but this is an extension not understood by some other implementations of grep (Michael Kebe reported an breakage on Solaris).

Rewrite the offending test to ERE and use egrep instead.
Noticed-by: Michael Kebe <michael.kebe@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 t/t1450-fsck.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to t/t1450-fsck.sh +1 −1
diff --git a/t/t1450-fsck.sh b/t/t1450-fsck.sh
index 8f52da2771..30e217dea2 100755
--- a/t/t1450-fsck.sh
+++ b/t/t1450-fsck.sh
@@ -541,7 +541,7 @@ test_expect_success 'fsck --name-objects' '
 		remove_loose_object $(git rev-parse julius:caesar.t) &&
 		test_must_fail git fsck --name-objects >out &&
 		tree=$(git rev-parse --verify julius:) &&
-		grep "$tree (\(refs/heads/master\|HEAD\)@{[0-9]*}:" out
+		egrep "$tree \((refs/heads/master|HEAD)@\{[0-9]*\}:" out
 	)
 '
 
-- 
2.13.2-655-gbf99380098

← back to recent threads