# Bug: submodules of submodules use absolute gitdir in .git file (instead of relative)

4 messages from 2017-06-27 to 2017-06-28. Participants: Robert Siemer, Junio C Hamano, Stefan Beller.
Thread: https://gitlist.dev/t/46268

## Robert Siemer, 2017-06-27 13:16

Subject: Bug: submodules of submodules use absolute gitdir in .git file (instead of relative)
Message-ID: <0d924a0671b642d2b8ba79af8d4fa0d7@rohde-schwarz.com>
URL: https://gitlist.dev/e/0d924a0671b642d2b8ba79af8d4fa0d7%40rohde-schwarz.com

```

Hello everyone,

$ git submodule foreach cat .git

...shows that the gitdir registered in the .git file of submodules is relative. But if you run 

$ git submodule foreach --recursive cat .git

...shows that submodules of submodules (if you have any) have an absolute gitdir starting with a slash.

1) Can you confirm that behavior?
2) Am I right that this is a bug (at least because of inconsistency)?


Regards,
Robert

```

## Junio C Hamano, 2017-06-27 15:06

Subject: Re: Bug: submodules of submodules use absolute gitdir in .git file (instead of relative)
Message-ID: <xmqqr2y531xv.fsf@gitster.mtv.corp.google.com>
URL: https://gitlist.dev/e/xmqqr2y531xv.fsf%40gitster.mtv.corp.google.com
In-Reply-To: <0d924a0671b642d2b8ba79af8d4fa0d7@rohde-schwarz.com>

```
Robert Siemer <Robert.Siemer@rohde-schwarz.com> writes:

> Hello everyone,
>
> $ git submodule foreach cat .git
>
> ...shows that the gitdir registered in the .git file of submodules is relative. But if you run 
>
> $ git submodule foreach --recursive cat .git
>
> ...shows that submodules of submodules (if you have any) have an absolute gitdir starting with a slash.
>
> 1) Can you confirm that behavior?

Nobody can without knowing which version of Git you are using.  I
suspect that we had discussed and addressed something related to
nested submodule's "gitdir" pointer in not-so-distant past.

> 2) Am I right that this is a bug (at least because of inconsistency)?


```

## Stefan Beller, 2017-06-27 17:35

Subject: Re: Bug: submodules of submodules use absolute gitdir in .git file (instead of relative)
Message-ID: <CAGZ79kZmV9Aufrsmf1iohhP5qHzA4AZ3DDv8sn1GMaCZ+SbV5Q@mail.gmail.com>
URL: https://gitlist.dev/e/CAGZ79kZmV9Aufrsmf1iohhP5qHzA4AZ3DDv8sn1GMaCZ%2BSbV5Q%40mail.gmail.com
In-Reply-To: <xmqqr2y531xv.fsf@gitster.mtv.corp.google.com>

```
On Tue, Jun 27, 2017 at 8:06 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Robert Siemer <Robert.Siemer@rohde-schwarz.com> writes:
>
>> Hello everyone,
>>
>> $ git submodule foreach cat .git
>>
>> ...shows that the gitdir registered in the .git file of submodules is relative. But if you run
>>
>> $ git submodule foreach --recursive cat .git
>>
>> ...shows that submodules of submodules (if you have any) have an absolute gitdir starting with a slash.
>>
>> 1) Can you confirm that behavior?
>
> Nobody can without knowing which version of Git you are using.  I
> suspect that we had discussed and addressed something related to
> nested submodule's "gitdir" pointer in not-so-distant past.

Yeah there was a period in time where we had this bug.
(Or is it a different bug?)
See 90c0011619 (submodule: use absolute path for computing
relative path connecting, 2016-12-08), which is included in 2.12.

```

## Robert Siemer, 2017-06-28 12:30

Subject: Re: Bug: submodules of submodules use absolute gitdir in .git file (instead of relative)
Message-ID: <a8e69eac41e747f79f8aba335f995d69@rohde-schwarz.com>
URL: https://gitlist.dev/e/a8e69eac41e747f79f8aba335f995d69%40rohde-schwarz.com
In-Reply-To: <a882773a8f0f4632a204090baa0f182b@rohde-schwarz.com>

```

I had the problem with version 2.7.4.

The problem is fixed in self-compiled v2.13.2.533.ge0aaa1bed, v2.12.0, v2.11.0 and v2.9.3! Even the older version 2.1.4 does not have that problem.

Thank you for the input!

Robert



________________________________________
From: Siemer Robert CSNPE
Sent: Wednesday, June 28, 2017 14:09
To: Stefan Beller; Junio C Hamano
Cc: git@vger.kernel.org
Subject: Re: Bug: submodules of submodules use absolute gitdir in .git file (instead of relative)

________________________________________
From: Stefan Beller <sbeller@google.com>
Sent: Tuesday, June 27, 2017 19:35
To: Junio C Hamano
Cc: Siemer Robert CSNPE; git@vger.kernel.org
Subject: Re: Bug: submodules of submodules use absolute gitdir in .git file (instead of relative)

On Tue, Jun 27, 2017 at 8:06 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Robert Siemer <Robert.Siemer@rohde-schwarz.com> writes:
>
>> Hello everyone,
>>
>> $ git submodule foreach cat .git
>>
>> ...shows that the gitdir registered in the .git file of submodules is relative. But if you run
>>
>> $ git submodule foreach --recursive cat .git
>>
>> ...shows that submodules of submodules (if you have any) have an absolute gitdir starting with a slash.
>>
>> 1) Can you confirm that behavior?
>
> Nobody can without knowing which version of Git you are using.  I
> suspect that we had discussed and addressed something related to
> nested submodule's "gitdir" pointer in not-so-distant past.

Yeah there was a period in time where we had this bug.
(Or is it a different bug?)
See 90c0011619 (submodule: use absolute path for computing
relative path connecting, 2016-12-08), which is included in 2.12.


```
